Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aos-sno-pair enhancement #831

Closed
wants to merge 11 commits into from
Closed

Conversation

mshitrit
Copy link
Contributor

Signed-off-by: Michael Shitrit mshitrit@redhat.com

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 12, 2021
@mshitrit mshitrit force-pushed the aos-sno-pair branch 3 times, most recently from eb51030 to fd310de Compare July 12, 2021 13:35
@mshitrit
Copy link
Contributor Author

/retest

1 similar comment
@mshitrit
Copy link
Contributor Author

/retest

@dhellmann
Copy link
Contributor

dhellmann commented Jul 13, 2021

If this is a priority for the current quarter or release, you can use /priority important-soon to indicate that.

@mshitrit mshitrit force-pushed the aos-sno-pair branch 2 times, most recently from 83999ab to 7afcbc7 Compare July 19, 2021 09:00
@mshitrit mshitrit changed the title WIP - aos-sno-pair enhancement aos-sno-pair enhancement Jul 19, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2021
enhancements/single-node/aos-sno-pair.md Outdated Show resolved Hide resolved
enhancements/single-node/aos-sno-pair.md Outdated Show resolved Hide resolved
enhancements/single-node/aos-sno-pair.md Outdated Show resolved Hide resolved
enhancements/single-node/aos-sno-pair.md Show resolved Hide resolved
enhancements/single-node/aos-sno-pair.md Show resolved Hide resolved
enhancements/single-node/aos-sno-pair.md Show resolved Hide resolved
enhancements/single-node/aos-sno-pair.md Show resolved Hide resolved
enhancements/single-node/aos-sno-pair.md Show resolved Hide resolved
enhancements/single-node/aos-sno-pair.md Show resolved Hide resolved
_The "two node cluster" is a use case that requires special consideration. With a standard two node cluster, each node with a single vote, there are 2 votes in the cluster. Using the simple majority calculation (50% of the votes + 1) to calculate quorum, the quorum would be 2. This means that the both nodes would always have to be alive for the cluster to be quorate and operate._
<br>Source: man votequorum

For environments in which customers will allow it, Corosync also ships a lightweight quorum arbitrator that can be run locally or in the cloud on any non-cluster node. In such cases, no special quorum handling is required and careful placement of the arbitrator also ensures that the surviving peer is reachable by its intended clients.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corosync is written in C what team supports this currently?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RHEL-HA

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've recently had some conversations about the difference in support lifecycles for RHEL and OCP. It would be good to call that out as a risk in this doc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't RHEL based products generally supported for much longer than OCP? What specific concerns have been raised?

The RHEL-HA team has a long history of being extremely responsive when bugs are found and proactive when it comes to backports.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, the RHEL lifetime was less than what we've been asked to support for OCP. Either way, the timelines don't always align, which makes extended support challenging sometimes.

enhancements/single-node/aos-sno-pair.md Show resolved Hide resolved
enhancements/single-node/aos-sno-pair.md Outdated Show resolved Hide resolved
Signed-off-by: Michael Shitrit <mshitrit@redhat.com>
enhancements/single-node/aos-sno-pair.md Show resolved Hide resolved
enhancements/single-node/aos-sno-pair.md Outdated Show resolved Hide resolved
enhancements/single-node/aos-sno-pair.md Show resolved Hide resolved
_The "two node cluster" is a use case that requires special consideration. With a standard two node cluster, each node with a single vote, there are 2 votes in the cluster. Using the simple majority calculation (50% of the votes + 1) to calculate quorum, the quorum would be 2. This means that the both nodes would always have to be alive for the cluster to be quorate and operate._
<br>Source: man votequorum

For environments in which customers will allow it, Corosync also ships a lightweight quorum arbitrator that can be run locally or in the cloud on any non-cluster node. In such cases, no special quorum handling is required and careful placement of the arbitrator also ensures that the surviving peer is reachable by its intended clients.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've recently had some conversations about the difference in support lifecycles for RHEL and OCP. It would be good to call that out as a risk in this doc.

mshitrit and others added 2 commits July 27, 2021 21:27
Co-authored-by: Andrew Beekhof <andrew@beekhof.net>
Signed-off-by: Michael Shitrit <mshitrit@redhat.com>
Signed-off-by: Michael Shitrit <mshitrit@redhat.com>
…ter"

* using relative link for resource file

Signed-off-by: Michael Shitrit <mshitrit@redhat.com>
Signed-off-by: Michael Shitrit <mshitrit@redhat.com>
Signed-off-by: Michael Shitrit <mshitrit@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign squeed after the PR has been reviewed.
You can assign the PR to them by writing /assign @squeed in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Michael Shitrit <mshitrit@redhat.com>
mshitrit and others added 3 commits August 4, 2021 17:19
Co-authored-by: Eran Cohen <eranco@redhat.com>
Signed-off-by: Michael Shitrit <mshitrit@redhat.com>
# Conflicts:
#	enhancements/single-node/aos-sno-pair.md
@openshift-bot
Copy link

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale.
Stale proposals rot after an additional 30d of inactivity and eventually close.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 22, 2021
@openshift-bot
Copy link

Stale enhancement proposals rot after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle rotten.
Rotten proposals close after an additional 7d of inactivity.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 29, 2021
@mshitrit
Copy link
Contributor Author

/remove-lifecycle stale

@mshitrit
Copy link
Contributor Author

/remove-lifecycle rotten

@openshift-ci openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 29, 2021
@beekhof
Copy link
Contributor

beekhof commented Oct 6, 2021

Closing this.
The conversation arrived at the conclusion that while the design is not objectionable, the result should not be part of ocp.
Will follow up with the ACM crew to see if it aligns with their goals.

@beekhof
Copy link
Contributor

beekhof commented Oct 6, 2021

/close

@openshift-ci openshift-ci bot closed this Oct 6, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2021

@beekhof: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mshitrit
Copy link
Contributor Author

mshitrit commented Oct 6, 2021

The conversation arrived at the conclusion that while the design is not objectionable, the result should not be part of ocp.
Will follow up with the ACM crew to see if it aligns with their goals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants