Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NE-310 Enhancement proposal for HSTS route admission plugin #849

Merged
merged 1 commit into from
Sep 24, 2021
Merged

NE-310 Enhancement proposal for HSTS route admission plugin #849

merged 1 commit into from
Sep 24, 2021

Conversation

candita
Copy link
Contributor

@candita candita commented Jul 29, 2021

Updates to the enhancement proposal after reaching feature complete.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2021
@candita candita force-pushed the NE-310-global-admission-hsts branch from c4522bf to afbf85f Compare July 29, 2021 02:57
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2021
@candita candita force-pushed the NE-310-global-admission-hsts branch from afbf85f to 7d5cb4a Compare August 12, 2021 22:52
@openshift-bot
Copy link

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale.
Stale proposals rot after an additional 30d of inactivity and eventually close.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 22, 2021
@candita
Copy link
Contributor Author

candita commented Sep 22, 2021

/remove-lifecycle-stale

@candita
Copy link
Contributor Author

candita commented Sep 22, 2021

/remove lifecycle-stale

@candita
Copy link
Contributor Author

candita commented Sep 23, 2021

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 23, 2021
@candita candita force-pushed the NE-310-global-admission-hsts branch from 7d5cb4a to ee2839f Compare September 23, 2021 22:03
@candita candita force-pushed the NE-310-global-admission-hsts branch from ee2839f to 27560b9 Compare September 23, 2021 22:07
@Miciah
Copy link
Contributor

Miciah commented Sep 24, 2021

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 24, 2021
@openshift-merge-robot openshift-merge-robot merged commit 1f41204 into openshift:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miciah Miciah Miciah left review comments

@sjenning sjenning Awaiting requested review from sjenning

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@Miciah Miciah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@candita @openshift-bot @Miciah @openshift-merge-robot