Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OCPNODE-677] Add conversin webhook for ICSP #863

Closed
wants to merge 1 commit into from

Conversation

QiWang19
Copy link
Member

Use conversion webhook for adding repositoryMirrors to ICSP.
The ImageContentSourcePolicy CRD needs a conversion webhook from
operator.openshift.io/v1alpha1 to operator.openshift.io/v1alpha2 for
adding new spec repositoryMirrors and deprecating repositoryDigestMirrors.

Signed-off-by: Qi Wang qiwan@redhat.com

Use conversion webhook for adding repositoryMirrors to ICSP.
The ImageContentSourcePolicy CRD needs a conversion webhook from
operator.openshift.io/v1alpha1 to operator.openshift.io/v1alpha2 for
adding new spec `repositoryMirrors` and deprecating `repositoryDigestMirrors`.

Signed-off-by: Qi Wang <qiwan@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign mandre after the PR has been reviewed.
You can assign the PR to them by writing /assign @mandre in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

@QiWang19: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/markdownlint 4f3edc3 link /test markdownlint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@QiWang19 QiWang19 changed the title Add conversin webhook for ICSP [OCPNODE-677] Add conversin webhook for ICSP Aug 12, 2021
@QiWang19 QiWang19 closed this Aug 20, 2021
@QiWang19 QiWang19 reopened this Aug 20, 2021
@QiWang19
Copy link
Member Author

Close the enhancement since we decide to handle both versions of the ICSP inside the MCO and the webhook is not needed. This will avoid taking the complexity of the webhook.

@QiWang19 QiWang19 closed this Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant