Console: expose network features #875
Conversation
| Operator (CNO). For example, the CNO would write a Config Map with a list of features, e.g.: | ||
|
|
||
| ```properties | ||
| network_policy_egress=true |
There was a problem hiding this comment.
Is this the full list of features you want to be exposed per CNI currently?
|
|
||
| ### Risks and Mitigations | ||
|
|
||
| To be evaluated. |
|
/assign @LalatenduMohanty |
|
Hi @LalatenduMohanty is there anything blocking the approval? |
|
|
||
| [In the new network policy creation forms, some fields may depend on the type | ||
| of cluster network type](https://issues.redhat.com/browse/NETOBSERV-16). | ||
| For example, `OpenShiftSDN` neither supports egress |
There was a problem hiding this comment.
** nor ingress ipblock exceptions
| ## Proposal | ||
|
|
||
| The Console UI should be able to read the set of features that the SDN component supports. These | ||
| features are accessed via a ConfigMap (read-only permissions) that is written by the Cloud Network |
There was a problem hiding this comment.
nit: Cluster Network Operator
|
|
||
| * If `features[F] === true`, then CNI type supports the feature. | ||
| * If `features[F] === false`, then the CNI type does not support the feature. | ||
| * If `features[F] === undefined`, then the feature' provider does not know |
There was a problem hiding this comment.
This shouldn't happen as we're not really asking the CNI to provide this information, the CNO (if it's deploying one of these CNIs should always know what features they support)
There was a problem hiding this comment.
Unless it's a 3rd party plugin, maybe we don't care as much about those..... i.e https://access.redhat.com/articles/5436171
There was a problem hiding this comment.
I was thinking on version skew between the CNO and the Console. E.g. a new version of the console that asks for a new network feature but the old version of the CNO does not return anything about its support status.
|
This lgtm for an initial merge, barring the small nit's I had (we can continue to work out the implementation details moving forward) |
|
/lgtm |
|
/unassign @LalatenduMohanty |
|
/assign @knobunc |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak, knobunc, martinkennelly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
The Console may need to show some fields that are exclusive to a given CNI type, and hide the fields that are not
provided by it. Then the console needs visibility about which CNI (
OpenShiftSDNorOVNKubernetes) featuresare available, depending on each customer's configuration.
This information should be available to all users (or, at this moment, to any user able to create
a Network Policy).