Add upstream CSI ports to proxy to #941
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertinatto
force-pushed
the
csi-metrics-ports
branch
from
c5c3b9a to
020c465
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jsafrane
reviewed
Oct 25, 2021
| @@ -78,6 +78,7 @@ Ports are assumed to be used on all nodes in all clusters unless otherwise speci | |||
| | 6385 | ironic-api | kni | 4.4 | baremetal provisioning, control plane only | | |||
| | 6443 | kube-apiserver | apiserver || control plane only | | |||
| | 8089 | ironic-conductor | kni | 4.4 | baremetal provisioning, control plane only | | |||
| | 8200-8219 | various CSI drivers | storage | 4.10 | metrics (upstream ports to proxy to) | | |||
There was a problem hiding this comment.
I think that the CSI sidecars listen on 127.0.0.1 and therefore should be in Localhost-only table below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @openshift/storage