Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KEP for vsphere CSI driver operator #961

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Nov 22, 2021

cc @openshift/sig-storage

@gnufied gnufied force-pushed the update-vsphere-driver-enhancement branch 2 times, most recently from 10856f3 to 5dfa4ed Compare November 22, 2021 21:42
@gnufied gnufied force-pushed the update-vsphere-driver-enhancement branch from 5dfa4ed to 195f3b4 Compare November 22, 2021 21:50
enhancements/storage/csi-vsphere-operator.md Outdated Show resolved Hide resolved
enhancements/storage/csi-vsphere-operator.md Show resolved Hide resolved
If additional VMs are added later into the cluster and they do not have HW version 15 or greater, Operator will mark itself as `degraded` and nodes which don't have right HW version will have annotation `vsphere.driver.status.csi.openshift.io: degraded` added to them.
When vSphere CSI operator starts, using credentials provided by cluster-storage-operator, it will first verifiy vCenter version and HW version of VMs.
If vCenter version is not 6.7u3 or greater and HW version is not 15 or greater on all VMs and this is a fresh install(i.e there is no `CSIDriver` object
already installed by this operator) - it will stop installation of vSphere CSI driver operator and periodically retry with exponential backoff.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to mention that this behavior is for 4.10 only and we will degrade the cluster in 4.11. Users have one release cycle to upgrade vCenter and all nodes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sine this timeline can change, I have not added it yet. but I added rest of the sections.

enhancements/storage/csi-vsphere-operator.md Outdated Show resolved Hide resolved
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2021

@gnufied: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link
Contributor

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 15, 2021
@openshift-merge-robot openshift-merge-robot merged commit 2913529 into openshift:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants