[cherry-pick openshift-4.0] *: Change gRPC proxy to expose etcd server endpoint /metrics #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR resolves an issue where the `/metrics` endpoints exposed by the proxy were not returning metrics of the etcd members servers but of the proxy itself. Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
openshift-ci-robot
added
the
size/L
|
/lgtm |
|
/cc @smarterclayton |
|
This change affects etcd gRPC-proxy only. |
|
Wait, cherrypicking to 4.0? From 4.1? You don't need to cherry-pick to release branches from master branches - is this just a code change from elsewhere? |
|
Oh, cherry-pick from upstream. Duh. |
|
lgtm too |
smarterclayton
added
the
approved
|
Why is tide not on for this repo? |
|
openshift/release#3454 turns on tide and approvals |
Merged
dusk125
pushed a commit
to dusk125/etcd
that referenced
this pull request
Jun 7, 2023
Signed-off-by: Chao Chen <chaochn@amazon.com>
dusk125
pushed a commit
to dusk125/etcd
that referenced
this pull request
Jun 7, 2023
migrate auth tests to common openshift#6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of etcd-io#10618 to openshift-4.0
etcd-io#10618: *: Change gRPC proxy to expose endpoint /metrics
This was originally merged into upstream master and then backported to upstream release-3.3 via etcd-io#10630
This PR is a fix to https://bugzilla.redhat.com/show_bug.cgi?id=1699045 blocking https://bugzilla.redhat.com/show_bug.cgi?id=1670700
/cc @brancz @s-urbaniak