-
Notifications
You must be signed in to change notification settings - Fork 16
[WIP] ESO-240: Bitwarden disable minimal cache #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[WIP] ESO-240: Bitwarden disable minimal cache #93
Conversation
Tested with 10,000 secretstores.
Memory goes from 28Mi to 200Mi but stays stable there.
No significant CPU spikes when webhook is called.
|
@mytreya-rh: This pull request references ESO-240 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mytreya-rh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This is to supplement the study done for ESO-240 which is documented at ESO-240: Study: Cleanup of Bitwarden deployment
The operator in this draft PR also hosts a webhook which caches bitwarden secretstores.
When (and only when) Bitwarden SDK deployment disable is attempted, the webhook is triggered which prevents the operation if (and only if) there are any secretstore/clustersecretstore that refer to Bitwarden.
Code is generated from Cursor using Claude-Sonnet-4.5 and good deal of feedback prompting and reigning in.
Tested with 10,000 SecretStores with memory usage going upto 220Mi max.