-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-2559 [mce-2.5] FIPS backports #2543
base: mce-2.5
Are you sure you want to change the base?
Conversation
As a result of the openshift installer transitioning from rhel8 to rhel9 (openshift/installer#8196), running openshift-install in the rhel8 backed hive container in order to install a cluster in fips mode results in a fips incompatibility. Create a seperate installmanager binary that runs the install-manager command previously invoked by hiveutil. Build a rhel8 and rhel9 version of hive, and copy both versions of installmanager to the installer container. The directory struture of the provisioning pod is also adjusted to support this change. Lastly, the installmanager binary corresponding to the rhel version of the installer container. Signed-off-by: Leah Leshchinsky <lleshchi@redhat.com>
Signed-off-by: Leah Leshchinsky <lleshchi@redhat.com>
New builder images do not alias python to python3 Signed-off-by: Antoni Segura Puimedon <antoni@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/security Requires a k8s bump, which we're not gonna do in this old of a release. |
@2uasimojo: Overrode contexts on behalf of 2uasimojo: ci/prow/security In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mce-2.5 #2543 +/- ##
========================================
Coverage 57.93% 57.93%
========================================
Files 186 186
Lines 26076 26075 -1
========================================
+ Hits 15106 15107 +1
+ Misses 9707 9705 -2
Partials 1263 1263
|
@2uasimojo: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Make mce-2.5 work for FIPS.
Picking this up from #2344
HIVE-2559