Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-2559 [mce-2.5] FIPS backports #2543

Open
wants to merge 3 commits into
base: mce-2.5
Choose a base branch
from
Open

HIVE-2559 [mce-2.5] FIPS backports #2543

wants to merge 3 commits into from

Conversation

2uasimojo
Copy link
Member

@2uasimojo 2uasimojo commented Jan 16, 2025

Make mce-2.5 work for FIPS.

Picking this up from #2344

HIVE-2559

lleshchi and others added 3 commits January 16, 2025 16:57
As a result of the openshift installer transitioning from rhel8 to rhel9
(openshift/installer#8196), running
openshift-install in the rhel8 backed hive container in order to install
a cluster in fips mode results in a fips incompatibility.

Create a seperate installmanager binary that runs the install-manager
command previously invoked by hiveutil. Build a rhel8 and rhel9 version
of hive, and copy both versions of installmanager to the installer
container. The directory struture of the provisioning pod is also
adjusted to support this change. Lastly, the installmanager binary
corresponding to the rhel version of the installer container.

Signed-off-by: Leah Leshchinsky <lleshchi@redhat.com>
Signed-off-by: Leah Leshchinsky <lleshchi@redhat.com>
New builder images do not alias python to python3

Signed-off-by: Antoni Segura Puimedon <antoni@redhat.com>
@openshift-ci openshift-ci bot requested review from dlom and jstuever January 16, 2025 23:01
Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2025
@2uasimojo
Copy link
Member Author

/override ci/prow/security

Requires a k8s bump, which we're not gonna do in this old of a release.

Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

@2uasimojo: Overrode contexts on behalf of 2uasimojo: ci/prow/security

In response to this:

/override ci/prow/security

Requires a k8s bump, which we're not gonna do in this old of a release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.93%. Comparing base (34c9d29) to head (261a1f2).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           mce-2.5    #2543   +/-   ##
========================================
  Coverage    57.93%   57.93%           
========================================
  Files          186      186           
  Lines        26076    26075    -1     
========================================
+ Hits         15106    15107    +1     
+ Misses        9707     9705    -2     
  Partials      1263     1263           
Files with missing lines Coverage Δ
contrib/pkg/utils/generic.go 9.75% <ø> (+0.30%) ⬆️
pkg/imageset/updateinstaller.go 45.06% <100.00%> (-0.67%) ⬇️
pkg/install/generate.go 43.15% <100.00%> (+0.49%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

@2uasimojo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e 261a1f2 link true /test e2e
ci/prow/security 261a1f2 link true /test security
ci/prow/e2e-pool 261a1f2 link true /test e2e-pool

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants