Fix Hive upstream image building #2547
Conversation
|
retest |
|
/retest |
|
I can't reproduce the image build issue locally, and I don't have access to https://console.redhat.com/application-pipeline/ns/crt-redhat-acm-tenant/pipelinerun/hive-mce-27-on-pull-request-x47vz/logs/build-container |
| @@ -1,6 +1,11 @@ | |||
| .PHONY: all | |||
| all: vendor update test build | |||
|
|
|||
| # These images needs to be synced with the default values in the Dockerfile. | |||
There was a problem hiding this comment.
| # These images needs to be synced with the default values in the Dockerfile. | |
| # These images need to be synced with the default values in the Dockerfile. |
| This approach is much faster than a full container build as it uses a base OS image, and binaries compiled on your host OS and then added to the container. *At present this is best suited for Fedora 33+.* | ||
| If you cannot login to registry.ci.openshift.org, a temporary solution is to use | ||
| public images during build and test. At the time of writing, the following public images | ||
| does the trick. |
There was a problem hiding this comment.
| does the trick. | |
| do the trick. |
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci
bot
added
lgtm
|
Thanks @2uasimojo , I will fix them. Beside that, I'm trying to confirm an issue that I have stumbled upon and I'm not yet sure if it is due to my own environment setup or this change. The containers, built with upstream images, fail to start with this error: |
I know CGO is Important™, but I can't remember exactly why, or whether it's supposed to be on or off, or what. Trying to find out. Also working on the konflux thing with @celebdor -- will override if necessary. Let's do this until we've at least got an answer on the CGO thing... /lgtm cancel |
|
@abraverm: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: abraverm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
removed
the
approved
Fedora development container is no longer working with the changes in Dockerfile, this change allows one to build Hive images without logging in to registry.ci.openshift.org.