contrib/cmd/hiveutil/awstagdeprovision: Add long description #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And document the matching logic. This makes usage more obvious for folks reading [1], who currently have no guidance on what awsFilter is. [1]: https://godoc.org/github.com/openshift/hive/contrib/pkg/awstagdeprovision
The cobra code is part of the command-line interface, and removing it reduces the dependency load on folks who are calling the library package from Go.
openshift-ci-robot
added
the
size/L
Explaining how multiple tag values interact. Also fix the usage instructions to show that one KEY=VALUE argument is required and more are optional, as documented in the SYNOPSIS section of [1]. [1]: http://man7.org/linux/man-pages/man7/man-pages.7.html#DESCRIPTION
wking
force-pushed
the
hiveutil-aws-deprovision-docs
branch
from
30368b5
to
6e7bacc
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #45; review that first. I can also rebase this onto master if you want it to go in before #45.
Explaining how multiple tag values interact.
Also fix the usage instructions to show that one
KEY=VALUEargument is required and more are optional, as documented in theSYNOPSISsection ofman-pages(7).