Set snapshot-count on etcd to limit memory usage variability #1448
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
See etcd-io/etcd#13889
tl;dr in etcd v3.2, upstream etcd increased the default snapshot count from 10k to 100k with very little rationale etcd-io/etcd#7160
This allows a lot more time for the etcd memory usage to rise before the snapshot is taken and memory can be released.
10k is the old default and this reverts to that old behavior in an effort to moderate the large memory usage swings we observe and allow for more a appropriate container memory request to be set.
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)
format, where issue_number might be a GitHub issue, or a Jira story:Fixes #
Checklist