Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOSTEDCP-2166: Add ability to set Labels on HCP Pods #5114

Merged
merged 2 commits into from
Nov 22, 2024
Merged

HOSTEDCP-2166: Add ability to set Labels on HCP Pods #5114

merged 2 commits into from
Nov 22, 2024

Conversation

muraee
Copy link
Contributor

@muraee muraee commented Nov 13, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2024
@muraee muraee changed the title WIP: Add ability to set Labels on HCP Pods WIP: HOSTEDCP-2166: Add ability to set Labels on HCP Pods Nov 13, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 13, 2024 •
edited by openshift-ci bot
Loading

@muraee: This pull request references HOSTEDCP-2166 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 13, 2024
@openshift-ci openshift-ci bot requested review from enxebre and sjenning November 13, 2024 12:18
@openshift-ci openshift-ci bot added area/api Indicates the PR includes changes for the API area/cli Indicates the PR includes changes for CLI area/documentation Indicates the PR includes changes for documentation and removed do-not-merge/needs-area labels Nov 13, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: muraee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Indicates the PR includes changes for e2e testing labels Nov 13, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 13, 2024 •
edited
Loading

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 81ecd6d
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/673f43394cc612000947bed4
😎 Deploy Preview https://deploy-preview-5114--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@muraee muraee force-pushed the feature-pods-labels branch from 3b4e214 to 9d3f2a5 Compare November 13, 2024 14:42
@muraee
Copy link
Contributor Author

muraee commented Nov 13, 2024

/test e2e-aws
/test e2e-aks

@openshift-ci openshift-ci bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Nov 13, 2024
@muraee muraee mentioned this pull request Nov 15, 2024
Merged
@muraee muraee force-pushed the feature-pods-labels branch from 9d3f2a5 to 4fe893d Compare November 15, 2024 16:03
@muraee
Copy link
Contributor Author

muraee commented Nov 18, 2024 •
edited
Loading

e2e will not pass until CNO/CSI changes are in place
CNO: openshift/cluster-network-operator#2567

{Failed  === RUN   TestCreateCluster/Main/EnsureCustomLabels
    util.go:1983: expected pods [aws-ebs-csi-driver-controller-6577df6849-z99b8, aws-ebs-csi-driver-operator-d77c79ff-n8cmm, cloud-network-config-controller-6b4fffd974-659lx, csi-snapshot-controller-5cdbcccd8-rsp9l, csi-snapshot-webhook-74f7dfb7df-j4vg2, multus-admission-controller-65dfd4fd64-4xhz2, network-node-identity-5669cb6bf4-b9f9n, ovnkube-control-plane-6dd8775f97-75f89] to have label hypershift-e2e-test-label=test
        --- FAIL: TestCreateCluster/Main/EnsureCustomLabels (0.02s)
}

@muraee muraee force-pushed the feature-pods-labels branch 3 times, most recently from defd9ca to 78e1f60 Compare November 18, 2024 16:30
enxebre
enxebre reviewed Nov 18, 2024
View reviewed changes
test/e2e/create_cluster_test.go Outdated
"": "test-value",
}
},
expectedErrorSubstring: "label key must have two segments: an optional prefix and name, separated by a slash (/). The name segment is required and must be 63 characters or less, beginning and ending with an alphanumeric character ([a-z0-9A-Z]) with dashes (-), underscores (_), dots (.), and alphanumerics between. The prefix is optional. If specified, the prefix must be a DNS subdomain: a series of DNS labels separated by dots (.), not longer than 253 characters in total, followed by a slash (/)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

@muraee muraee force-pushed the feature-pods-labels branch 2 times, most recently from f36dda6 to ee18d85 Compare November 19, 2024 12:27
@muraee muraee force-pushed the feature-pods-labels branch 2 times, most recently from 5e9697e to d93215e Compare November 19, 2024 14:00
@muraee
Copy link
Contributor Author

muraee commented Nov 20, 2024

/retest-required

1 similar comment
@muraee
Copy link
Contributor Author

muraee commented Nov 20, 2024

/retest-required

@muraee muraee changed the title WIP: HOSTEDCP-2166: Add ability to set Labels on HCP Pods HOSTEDCP-2166: Add ability to set Labels on HCP Pods Nov 21, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2024
@enxebre
Copy link
Member

enxebre commented Nov 21, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6f18591 and 2 for PR HEAD d93215e in total

@muraee muraee force-pushed the feature-pods-labels branch from d93215e to 81ecd6d Compare November 21, 2024 14:27
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2024
@muraee muraee force-pushed the feature-pods-labels branch from 81ecd6d to e91708b Compare November 21, 2024 14:27
@enxebre
Copy link
Member

enxebre commented Nov 21, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f0571d2 and 2 for PR HEAD e91708b in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD be0b725 and 1 for PR HEAD e91708b in total

@celebdor
Copy link
Contributor

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e5bfefc and 0 for PR HEAD e91708b in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

@muraee: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 389cea7 into openshift:main Nov 22, 2024
16 checks passed
@muraee muraee mentioned this pull request Nov 26, 2024
Merged
This was referenced Jan 6, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre enxebre left review comments

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@enxebre enxebre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Indicates the PR includes changes for the API area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@muraee @openshift-ci-robot @enxebre @celebdor