NO-JIRA: openstack/e2e: allow to change AZ name #5138
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@EmilienM: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-openstack |
openshift-ci
bot
added
the
area/testing
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -562,9 +562,8 @@ func (p *options) DefaultOpenStackOptions() hypershiftopenstack.RawCreateOptions | |||
| OpenStackExternalNetworkID: p.configurableClusterOptions.OpenStackExternalNetworkID, | |||
| NodePoolOpts: &openstacknodepool.RawOpenStackPlatformCreateOptions{ | |||
| OpenStackPlatformOptions: &openstacknodepool.OpenStackPlatformOptions{ | |||
| Flavor: p.configurableClusterOptions.OpenStackNodeFlavor, | |||
| ImageName: p.configurableClusterOptions.OpenStackNodeImageName, | |||
| AvailabityZone: p.configurableClusterOptions.OpenStackNodeAvailabilityZone, | |||
There was a problem hiding this comment.
we don't want all Nodepools to have AZ specified, so we remove it from here. This change is expected.
| if globalOpts.configurableClusterOptions.OpenStackNodeAvailabilityZone != "" { | ||
| return globalOpts.configurableClusterOptions.OpenStackNodeAvailabilityZone | ||
| } | ||
| return defaultAvailabilityZone |
There was a problem hiding this comment.
the default AZ "nova" is safe, as it's present in most clouds. Though it's good we can easily override it.
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/test e2e-openstack |
In some environments, we'll want to change the name of the availability zone where the nodepool AZ will be tested on. Let's allow that with this change.
|
/test e2e-openstack |
1 similar comment
|
/test e2e-openstack |
|
@EmilienM: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
In some environments, we'll want to change the name of the availability
zone where the nodepool AZ will be tested on.
Let's allow that with this change.