Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOSTEDCP-2075: Nodeport address cel #5172

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Nov 21, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 21, 2024

@enxebre: This pull request references HOSTEDCP-2075 which is a valid jira issue.

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 21, 2024
Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 9d242cf
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/673f6fade3d0260008932a4d
😎 Deploy Preview https://deploy-preview-5172--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@openshift-ci openshift-ci bot added area/api Indicates the PR includes changes for the API area/cli Indicates the PR includes changes for CLI area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels Nov 21, 2024
Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2024
@enxebre
Copy link
Member Author

enxebre commented Nov 22, 2024

/retest

@enxebre
Copy link
Member Author

enxebre commented Nov 22, 2024

/test e2e-aks

1 similar comment
@enxebre
Copy link
Member Author

enxebre commented Nov 22, 2024

/test e2e-aks

@muraee
Copy link
Contributor

muraee commented Nov 26, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD da24e17 and 2 for PR HEAD 9d242cf in total

7 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD da24e17 and 2 for PR HEAD 9d242cf in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD da24e17 and 2 for PR HEAD 9d242cf in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD da24e17 and 2 for PR HEAD 9d242cf in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD da24e17 and 2 for PR HEAD 9d242cf in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD da24e17 and 2 for PR HEAD 9d242cf in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD da24e17 and 2 for PR HEAD 9d242cf in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD da24e17 and 2 for PR HEAD 9d242cf in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
Copy link
Contributor

openshift-ci bot commented Nov 27, 2024

New changes are detected. LGTM label has been removed.

Copy link
Contributor

openshift-ci bot commented Nov 27, 2024

@enxebre: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-4-17 1175031 link true /test e2e-aws-4-17
ci/prow/e2e-aws 1175031 link true /test e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Indicates the PR includes changes for the API area/cli Indicates the PR includes changes for CLI area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants