-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow egress-http-proxy.sh to be run as non-root #162
base: master
Are you sure you want to change the base?
Conversation
Pidfiles are not useful in the container, so tell squid to not create one (otherwise it needs to be root so that it can write to /run/squid.pid). Output squid.conf to /tmp so that the script can be run as non-root.
Hi @yrro. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/refresh |
Since openshift/release#48854 merged, we now have unit tests. |
/lgtm |
/assign |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yrro The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yrro The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@yrro: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@yrro if this is still needed, can you please file a Jira bug report to renew this PR request, and update the title to refer to the Jira id? |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
I'd like to be able to deploy this image without running as root.
The necessary changes are quite simple:
/tmp
)