Bug 1881044: Limit the maximum number of CSR #184

rluders · 2020-09-21T12:43:55Z

Apply some limits to the CSR request to avoid memory issues.

openshift-ci-robot · 2020-09-21T12:43:59Z

@rluders: This pull request references Bugzilla bug 1881044, which is invalid:

expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1881044: Limit the maximum number of CSR per request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-09-21T12:44:18Z

Hi @rluders. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tremes · 2020-09-22T08:53:31Z

lgtm

0sewa0 · 2020-09-22T10:25:11Z

lgtm

tisnik

LGTM!

tisnik · 2020-09-23T10:27:37Z

/lgtm

rluders · 2020-09-25T07:42:51Z

/ok-to-test

rluders · 2020-09-25T07:44:20Z

/bugzilla refresh

openshift-ci-robot · 2020-09-25T07:44:23Z

@rluders: This pull request references Bugzilla bug 1881044, which is invalid:

expected the bug to target the "4.6.0" release, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rluders · 2020-09-25T07:45:32Z

/retest

openshift-bot · 2020-09-25T11:00:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-25T11:38:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-25T11:51:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-25T12:04:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-25T12:18:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-25T12:30:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-25T12:56:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-25T16:11:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-25T16:50:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-25T17:55:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-25T18:08:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

tremes · 2020-09-28T08:58:42Z

/lgtm

natiiix

/lgtm

Seems simple enough, so I didn't generate a cluster to test this locally.

openshift-ci-robot · 2020-09-28T09:05:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natiiix, rluders, tisnik, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [natiiix,rluders,tisnik,tremes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-09-29T01:00:39Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-09-29T01:00:41Z

@openshift-bot: This pull request references Bugzilla bug 1881044, which is invalid:

expected the bug to target the "4.6.0" release, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rluders · 2020-09-29T09:19:51Z

/bugzilla refresh

openshift-ci-robot · 2020-09-29T09:19:57Z

@rluders: An error was encountered adding this pull request to the external tracker bugs for bug 1881044 on the Bugzilla server at https://bugzilla.redhat.com:

JSONRPC error 32000: There was an error reported for a GitHub REST call. URL: https://api.github.com/repos/openshift/insights-operator/pulls/184 Error: 403 Forbidden at /loader/0x5589446ba9a8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. at /loader/0x5589446ba9a8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. eval {...} called at /loader/0x5589446ba9a8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 98 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x55894c...', 'https://api.github.com/repos/openshift/insights-operator/pull...', 'GET') called at /loader/0x5589446ba9a8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x55894c...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x55894c756ae8)') called at /loader/0x5589446ba9a8/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x5589446ba9a8/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x55894c756ae8)', 1) called at /loader/0x5589446ba9a8/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x55894c7549b0)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 877 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x55894ca8d0a0)', 'HASH(0x55894c0e1910)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x55894c0e1910)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1170 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x55894cb942d0)') called at /loader/0x5589446ba9a8/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55894c841558)') called at (eval 2109) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55894c2a8ef8)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 295 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55894c2a8ef8)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x55894bda00b8)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x55894c961e70)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x55894c961e70)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x55894bda00b8)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x55894bda00b8)') called at (eval 2109) line 0 eval {...} called at (eval 2109) line 0
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rluders · 2020-09-29T09:36:10Z

/bugzilla refresh

openshift-ci-robot · 2020-09-29T09:36:15Z

@rluders: This pull request references Bugzilla bug 1881044, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rluders · 2020-09-29T11:21:22Z

/retest

rluders · 2020-09-29T12:14:06Z

/retest

rluders · 2020-09-29T13:55:20Z

/test e2e-aws

openshift-bot · 2020-09-29T14:39:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-29T15:44:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-09-29T17:32:06Z

@rluders: All pull requests linked via external trackers have merged:

openshift/insights-operator#184

Bugzilla bug 1881044 has been moved to the MODIFIED state.

In response to this:

Bug 1881044: Limit the maximum number of CSR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Limit the maximum number of CSR per request

8130881

openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Sep 21, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 21, 2020

openshift-ci-robot requested review from derekwaynecarr and tisnik September 21, 2020 12:44

openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 21, 2020

Limit the maximum number of CSR

d6fd9e4

rluders changed the title ~~Bug 1881044: Limit the maximum number of CSR per request~~ Bug 1881044: Limit the maximum number of CSR Sep 21, 2020

tisnik approved these changes Sep 23, 2020

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2020

openshift-ci-robot assigned tisnik Sep 23, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2020

openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 25, 2020

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2020

Merge branch 'master' into limit-csr-per-request

1f37362

openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 28, 2020

rluders requested a review from tisnik September 28, 2020 08:55

openshift-ci-robot assigned tremes Sep 28, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2020

natiiix approved these changes Sep 28, 2020

View reviewed changes

openshift-ci-robot assigned natiiix Sep 28, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 29, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 29, 2020

openshift-merge-robot merged commit 9c195e2 into openshift:master Sep 29, 2020

Bug 1881044: Limit the maximum number of CSR #184

Bug 1881044: Limit the maximum number of CSR #184

Uh oh!

Conversation

rluders commented Sep 21, 2020

Uh oh!

openshift-ci-robot commented Sep 21, 2020

Uh oh!

openshift-ci-robot commented Sep 21, 2020

Uh oh!

tremes commented Sep 22, 2020

Uh oh!

0sewa0 commented Sep 22, 2020

Uh oh!

tisnik left a comment

Choose a reason for hiding this comment

Uh oh!

tisnik commented Sep 23, 2020

Uh oh!

rluders commented Sep 25, 2020

Uh oh!

rluders commented Sep 25, 2020

Uh oh!

openshift-ci-robot commented Sep 25, 2020

Uh oh!

rluders commented Sep 25, 2020

Uh oh!

openshift-bot commented Sep 25, 2020

Uh oh!

openshift-bot commented Sep 25, 2020

Uh oh!

openshift-bot commented Sep 25, 2020

Uh oh!

openshift-bot commented Sep 25, 2020

Uh oh!

openshift-bot commented Sep 25, 2020

Uh oh!

openshift-bot commented Sep 25, 2020

Uh oh!

openshift-bot commented Sep 25, 2020

Uh oh!

openshift-bot commented Sep 25, 2020

Uh oh!

openshift-bot commented Sep 25, 2020

Uh oh!

openshift-bot commented Sep 25, 2020

Uh oh!

openshift-bot commented Sep 25, 2020

Uh oh!

tremes commented Sep 28, 2020

Uh oh!

natiiix left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Sep 28, 2020

Uh oh!

openshift-bot commented Sep 29, 2020

Uh oh!

openshift-ci-robot commented Sep 29, 2020

Uh oh!

rluders commented Sep 29, 2020

Uh oh!

openshift-ci-robot commented Sep 29, 2020

Uh oh!

rluders commented Sep 29, 2020

Uh oh!

openshift-ci-robot commented Sep 29, 2020

Uh oh!

rluders commented Sep 29, 2020

Uh oh!

rluders commented Sep 29, 2020

Uh oh!

rluders commented Sep 29, 2020

Uh oh!

openshift-bot commented Sep 29, 2020

Uh oh!

openshift-bot commented Sep 29, 2020

Uh oh!

openshift-ci-robot commented Sep 29, 2020

Uh oh!