-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1885930: Gather ServiceAccounts stats from cluster namespaces #200
Bug 1885930: Gather ServiceAccounts stats from cluster namespaces #200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't run the code yet, but I'll do it later, but looks good.
It looks good to me in general. Maybe we should increase
|
1ab8790
to
cb458c4
Compare
cb458c4
to
7a0b3ac
Compare
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: martinkunc, tremes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@martinkunc: All pull requests linked via external trackers have merged: Bugzilla bug 1885930 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.6 |
@martinkunc: new pull request created: #206 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.5 |
@martinkunc: #200 failed to apply on top of branch "release-4.5":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.4 |
@martinkunc: #200 failed to apply on top of branch "release-4.4":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Gather ServiceAccounts stats from cluster namespaces Fix buid with missing library by using -mod=vendor
Gather ServiceAccounts stats from cluster namespaces Fix buid with missing library by using -mod=vendor Please enter the commit message for your changes. Lines starting
Gather ServiceAccounts stats from cluster namespaces Fix buid with missing library by using -mod=vendor
Gather ServiceAccounts stats from cluster namespaces Fix buid with missing library by using -mod=vendor Please enter the commit message for your changes. Lines starting
Gather ServiceAccounts stats from cluster namespaces Fix buid with missing library by using -mod=vendor Please enter the commit message for your changes. Lines starting
Gather ServiceAccounts stats from cluster namespaces Fix buid with missing library by using -mod=vendor
Gather ServiceAccounts stats from cluster namespaces Fix buid with missing library by using -mod=vendor
* [4.5] Adds PodDisruptionBudgets gather. * Merge pull request #200 from martinkunc/gather-serviceaccounts Gather ServiceAccounts stats from cluster namespaces Fix buid with missing library by using -mod=vendor Please enter the commit message for your changes. Lines starting * Merge pull request #200 from martinkunc/gather-serviceaccounts Gather ServiceAccounts stats from cluster namespaces Fix buid with missing library by using -mod=vendor * Fix some issues by rebase * Removing some variables from makefile Co-authored-by: Marcell Sevcsik <msevcsik@redhat.com> Co-authored-by: OpenShift Merge Robot <openshift-merge-robot@users.noreply.github.com> Co-authored-by: Martin Kunc <5441732+martinkunc@users.noreply.github.com>
The change is collecting numbers of service accounts from kubernetes default namespaces and openshift built-in namespaces (openshift*).
It would be used to detect that a particular SA exists in ns, specifically to target https://access.redhat.com/solutions/5221881 and find lib-bucket-provisioner from NS openshift-storage