Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error in default Smart proxy report endpoint #212

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Fix error in default Smart proxy report endpoint #212

merged 1 commit into from
Oct 13, 2020

Conversation

joselsegura
Copy link
Contributor

No description provided.

rluders
rluders approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joselsegura, rluders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2020
@rluders
Copy link
Contributor

rluders commented Oct 13, 2020

BTW, I'm surprised that these values are fixed in code and not coming from some configmap or somethig. 🤔

@joselsegura
Copy link
Contributor Author

BTW, I'm surprised that these values are fixed in code and not coming from some configmap or somethig. thinking

It can be read from the configobserver package too from the cluster secrets, or by the configuration parser in the configuration file... but the default one if all of them are missing is incorrect, that leads in an IO that cannot retrieve the report

@rluders
Copy link
Contributor

rluders commented Oct 13, 2020 •
edited
Loading

all of them are missing is incorrect, that leads in an IO that cannot retrieve the

I see. It makes sense.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@joselsegura
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit adf9b28 into openshift:master Oct 13, 2020
@joselsegura joselsegura deleted the fix_default_endpoint branch October 14, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rluders rluders rluders approved these changes

@natiiix natiiix Awaiting requested review from natiiix

Assignees

@rluders rluders

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joselsegura @openshift-ci-robot @rluders @openshift-bot @openshift-merge-robot