Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1917799: Gather list of OLM operator names and versions & minor clean up #316

Merged
merged 5 commits into from
Jan 27, 2021

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Jan 18, 2021

This PR gathers all the names & versions of the installed OLM operators using dynamic client & some clean up.

I am still wondering what the relation between ClusterServiceVersion and Operator kind is and why the versions (v1alpha1 and v1) are different when both are from operators.coreos.com. The sets of these kinds are not equal that's why I implemented with using Operator, but it would be much more straightforward using ClusterServiceVersion.

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample archive

  • docs/insights-archive-sample/config/olm_operators.json

Documentation

  • docs/gathered-data.md

Unit Tests

  • pkg/gather/clusterconfig/olm_operators_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Not yet

References

https://issues.redhat.com/browse/???
https://bugzilla.redhat.com/show_bug.cgi?id=???
https://access.redhat.com/solutions/???

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2021
@tremes
Copy link
Contributor Author

tremes commented Jan 19, 2021

/test insights-operator-e2e-tests

@tremes tremes changed the title Gather list of OLM operator names and versions & minor clean up Bug 1917799: Gather list of OLM operator names and versions & minor clean up Jan 19, 2021
@openshift-ci-robot
Copy link
Contributor

@tremes: This pull request references Bugzilla bug 1917799, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1917799: Gather list of OLM operator names and versions & minor clean up

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 19, 2021
@tremes tremes force-pushed the olm_poc_crazy_version branch from f4ddcec to 6dff66f Compare January 19, 2021 13:34
@tremes
Copy link
Contributor Author

tremes commented Jan 20, 2021

/retest

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2021
@tremes tremes force-pushed the olm_poc_crazy_version branch from b4627c4 to 8439de6 Compare January 25, 2021 07:21
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 25, 2021
@tremes
Copy link
Contributor Author

tremes commented Jan 25, 2021

/retest

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2021
@tremes tremes force-pushed the olm_poc_crazy_version branch from 8439de6 to 250e693 Compare January 26, 2021 06:52
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2021
@0sewa0
Copy link
Contributor

0sewa0 commented Jan 27, 2021

Tested it with cluster-bot.

  • Installed 2 OLM operators using the web UI
  • Applied the 03-clusterrole.yaml
  • Got output [{"name":"awx-resource-operator.openshift-operator-lifecycle-manager","version":"v0.1.0"},{"name":"kiali-ossm.openshift-operators","version":"v1.24.4"}]

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@tremes tremes force-pushed the olm_poc_crazy_version branch from 250e693 to e2d14ea Compare January 27, 2021 15:12
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2021
@0sewa0
Copy link
Contributor

0sewa0 commented Jan 27, 2021

tested it again, same as before (but only installed 1 OLM operator)
Got output: [{"name":"awx-resource-operator.default","version":"v0.1.0"}]

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0sewa0, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e758cd0 into openshift:master Jan 27, 2021
@openshift-ci-robot
Copy link
Contributor

@tremes: All pull requests linked via external trackers have merged:

Bugzilla bug 1917799 has been moved to the MODIFIED state.

In response to this:

Bug 1917799: Gather list of OLM operator names and versions & minor clean up

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes tremes deleted the olm_poc_crazy_version branch September 14, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants