Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.7] Bug 1935070: Extend the OLM operator data with related … #362

Merged
merged 2 commits into from
Mar 23, 2021

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Mar 4, 2021

…ClusterServiceVersion conditions (#358)

Getting more data about installed OLM operators and create corresponding upgrade report is one of the CCX goals. This PR extends the data with corresponding Operator/ClusterServiceVersion conditions and doesn't add any new gatherer or other functionality. See the CCX epics below.

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample archive

Updated in:

  • docs/insights-archive-sample/config/olm_operators.json

Documentation

Documentation updated in:

  • docs/gathered-data.md

Unit Tests

Unit test updated in:

  • pkg/gather/clusterconfig/olm_operators_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

References

https://issues.redhat.com/browse/CCXDEV-719
https://issues.redhat.com/browse/CCXDEV-3965
https://issues.redhat.com/browse/CCXDEV-3966
https://bugzilla.redhat.com/show_bug.cgi?id=1935070
https://access.redhat.com/solutions/???

…ClusterServiceVersion conditions (openshift#358)

* Extend the OLM operator data with related ClusterServiceVersion
conditions

* Update sample archive

* Update the OLM operators test

* Fix
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 4, 2021
@openshift-ci-robot
Copy link
Contributor

@tremes: This pull request references Bugzilla bug 1935070, which is invalid:

  • expected dependent Bugzilla bug 1934397 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 1935070: Extend the OLM operator data with related …

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2021
@tremes
Copy link
Contributor Author

tremes commented Mar 5, 2021

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 5, 2021
@openshift-ci-robot
Copy link
Contributor

@tremes: This pull request references Bugzilla bug 1935070, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1934397 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1934397 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@0sewa0
Copy link
Contributor

0sewa0 commented Mar 8, 2021

/retest

@0sewa0
Copy link
Contributor

0sewa0 commented Mar 9, 2021

/lgtm

Tested it on cluster-bot cluster, produced file:

[
    {
        "name": "crunchy-postgres-operator.default",
        "version": "v4.5.0",
        "csv_conditions": [
            {
                "lastTransitionTime": "2021-03-09T08:15:43Z",
                "lastUpdateTime": "2021-03-09T08:15:43Z",
                "message": "requirements not yet checked",
                "phase": "Pending",
                "reason": "RequirementsUnknown"
            },
            {
                "lastTransitionTime": "2021-03-09T08:15:43Z",
                "lastUpdateTime": "2021-03-09T08:15:43Z",
                "message": "one or more requirements couldn't be found",
                "phase": "Pending",
                "reason": "RequirementsNotMet"
            },
            {
                "lastTransitionTime": "2021-03-09T08:15:43Z",
                "lastUpdateTime": "2021-03-09T08:15:43Z",
                "message": "all requirements found, attempting install",
                "phase": "InstallReady",
                "reason": "AllRequirementsMet"
            },
            {
                "lastTransitionTime": "2021-03-09T08:15:44Z",
                "lastUpdateTime": "2021-03-09T08:15:44Z",
                "message": "waiting for install components to report healthy",
                "phase": "Installing",
                "reason": "InstallSucceeded"
            },
            {
                "lastTransitionTime": "2021-03-09T08:15:44Z",
                "lastUpdateTime": "2021-03-09T08:15:44Z",
                "message": "installing: waiting for deployment postgres-operator to become ready: Waiting for rollout to finish: 0 of 1 updated replicas are available...\n",
                "phase": "Installing",
                "reason": "InstallWaiting"
            },
            {
                "lastTransitionTime": "2021-03-09T08:16:24Z",
                "lastUpdateTime": "2021-03-09T08:16:24Z",
                "message": "install strategy completed with no errors",
                "phase": "Succeeded",
                "reason": "InstallSucceeded"
            }
        ]
    }
]

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0sewa0, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@ecordell ecordell added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 22, 2021
@tremes
Copy link
Contributor Author

tremes commented Mar 23, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit 56d6896 into openshift:release-4.7 Mar 23, 2021
@openshift-ci-robot
Copy link
Contributor

@tremes: All pull requests linked via external trackers have merged:

Bugzilla bug 1935070 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 1935070: Extend the OLM operator data with related …

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes tremes deleted the extend_olm_4.7 branch May 6, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants