Bug 1949907: Gather summary of PodNetworkConnectivityChecks #374

natiiix · 2021-03-12T15:13:36Z

This PR implements a new data enhancement for gathering a summary of PodNetworkConnectivityChecks. Time of the most recently failed check with each reason and message is recorded in the IO archive. This enhancement is proactive and will not be backported.

Sample archive

docs/insights-archive-sample/config/podnetworkconnectivitychecks.json

Documentation

docs/gathered-data.md - "PNCC" section

Unit Tests

pkg/gather/clusterconfig/pod_network_connectivity_checks_test.go - Test_PNCC

Privacy

⚠️ Gathered data may contain external IP addresses and ports of services (i.e., when an important service is unreachable). ⚠️

Changelog

No.

References

Jira Task: https://issues.redhat.com/browse/CCXDEV-4192
Bugzilla Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1949907

pkg/gather/clusterconfig/pod_network_connectivity_checks.go

natiiix · 2021-04-14T08:30:49Z

/retest
No idea why they're failing. The 503 status is suspicious and doesn't seem like an IO-related problem.

pkg/gather/clusterconfig/pod_network_connectivity_checks.go

docs/insights-archive-sample/config/podnetworkconnectivitychecks.json

natiiix · 2021-04-19T08:46:48Z

/test e2e

natiiix · 2021-04-20T02:56:30Z

/retest

pkg/gather/clusterconfig/pod_network_connectivity_checks_test.go

pkg/gather/clusterconfig/pod_network_connectivity_checks.go

tremes · 2021-04-23T08:42:46Z

/retest

docs/gathered-data.md

Apparently Go has a nice idiomatic way of doing this task which is usually quite ugly in most other languages.

tremes · 2021-04-23T11:39:09Z

I went through the code and ran it locally. Thanks!
/lgtm

openshift-ci-robot · 2021-04-23T11:39:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natiiix, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [natiiix,tremes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2021-04-23T11:41:51Z

@natiiix: This pull request references Bugzilla bug 1949907, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @psimovec

In response to this:

Bug 1949907: Gather summary of PodNetworkConnectivityChecks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-04-23T11:48:23Z

@natiiix: This pull request references Bugzilla bug 1949907, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @psimovec

In response to this:

Bug 1949907: Gather summary of PodNetworkConnectivityChecks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-23T13:18:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-24T07:56:55Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-24T10:04:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-24T11:20:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-04-24T12:11:24Z

@natiiix: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-gcp-upgrade	`74b4902`	link	`/test e2e-gcp-upgrade`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-04-24T13:05:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-24T13:56:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2021-04-24T15:10:06Z

@natiiix: All pull requests linked via external trackers have merged:

openshift/insights-operator#374

Bugzilla bug 1949907 has been moved to the MODIFIED state.

In response to this:

Bug 1949907: Gather summary of PodNetworkConnectivityChecks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

natiiix · 2021-04-26T04:11:36Z

🎉 That took an awful lot of attempts to pass the CI. 🙃

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2021

openshift-ci-robot requested review from rluders and smarterclayton March 12, 2021 15:13

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2021

natiiix marked this pull request as draft March 12, 2021 15:16

natiiix force-pushed the pncc branch from 4588d17 to c53ee95 Compare March 15, 2021 11:28

natiiix force-pushed the pncc branch 2 times, most recently from 373a0ee to 543d26a Compare April 6, 2021 08:31

natiiix force-pushed the pncc branch 2 times, most recently from 051348e to 17299cb Compare April 13, 2021 08:22

natiiix changed the title ~~WIP: PodNetworkConnectivityChecks~~ Gather summary of PodNetworkConnectivityChecks Apr 13, 2021

natiiix marked this pull request as ready for review April 13, 2021 08:35

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2021

rluders suggested changes Apr 13, 2021

View reviewed changes

pkg/gather/clusterconfig/pod_network_connectivity_checks.go Outdated Show resolved Hide resolved

pkg/gather/clusterconfig/pod_network_connectivity_checks.go Outdated Show resolved Hide resolved

tremes reviewed Apr 14, 2021

View reviewed changes

pkg/gather/clusterconfig/pod_network_connectivity_checks.go Show resolved Hide resolved

tremes reviewed Apr 14, 2021

View reviewed changes

docs/insights-archive-sample/config/podnetworkconnectivitychecks.json Outdated Show resolved Hide resolved

natiiix force-pushed the pncc branch 2 times, most recently from 1219d4c to 292c9e7 Compare April 16, 2021 15:17

tremes reviewed Apr 22, 2021

View reviewed changes

pkg/gather/clusterconfig/pod_network_connectivity_checks_test.go Outdated Show resolved Hide resolved

tremes reviewed Apr 22, 2021

View reviewed changes

pkg/gather/clusterconfig/pod_network_connectivity_checks.go Outdated Show resolved Hide resolved

natiiix force-pushed the pncc branch from 292c9e7 to 74b4902 Compare April 22, 2021 10:33

tremes reviewed Apr 23, 2021

View reviewed changes

docs/gathered-data.md Show resolved Hide resolved

natiiix added 4 commits April 23, 2021 12:35

Add permissions for PodNetworkConnectivityChecks

9db7984

Gather PodNetworkConnectivityChecks

dea368a

Fix PNCC name

2f88e3d

Gather PNCC info

c6dace6

natiiix added 8 commits April 23, 2021 12:35

Fix PNCC reason/message counter logic

3fee1e3

Apparently Go has a nice idiomatic way of doing this task which is usually quite ugly in most other languages.

Add version information to PNCC gatherer

d7df396

Gather time of last failed PNCC instead of count

6bf997f

Fix PNCC test comments

643628f

Remove coreClient from PNCC gatherer

5cafdc4

Add detailed note to PNCC gatherer comment

884b0d2

Update PNCC docs in gathered-data

3ff97a8

Update PNCC in sample archive

e7c3163

natiiix force-pushed the pncc branch from 74b4902 to e7c3163 Compare April 23, 2021 10:35

Make PNCC gatherer failable

5c84f1f

openshift-ci-robot assigned tremes Apr 23, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2021

natiiix changed the title ~~Gather summary of PodNetworkConnectivityChecks~~ Bug 1949907: Gather summary of PodNetworkConnectivityChecks Apr 23, 2021

openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 23, 2021

openshift-ci-robot requested a review from psimovec April 23, 2021 11:41

openshift-merge-robot merged commit 0f5d26c into openshift:master Apr 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1949907: Gather summary of PodNetworkConnectivityChecks #374

Bug 1949907: Gather summary of PodNetworkConnectivityChecks #374

natiiix commented Mar 12, 2021 •

edited

Loading

natiiix commented Apr 14, 2021

natiiix commented Apr 19, 2021

natiiix commented Apr 20, 2021

tremes commented Apr 23, 2021

tremes commented Apr 23, 2021

openshift-ci-robot commented Apr 23, 2021

openshift-ci-robot commented Apr 23, 2021

openshift-ci-robot commented Apr 23, 2021

openshift-bot commented Apr 23, 2021

openshift-bot commented Apr 24, 2021

openshift-bot commented Apr 24, 2021

openshift-bot commented Apr 24, 2021

openshift-ci bot commented Apr 24, 2021 •

edited

Loading

openshift-bot commented Apr 24, 2021

openshift-bot commented Apr 24, 2021

openshift-ci-robot commented Apr 24, 2021

natiiix commented Apr 26, 2021

Bug 1949907: Gather summary of PodNetworkConnectivityChecks #374

Bug 1949907: Gather summary of PodNetworkConnectivityChecks #374

Conversation

natiiix commented Mar 12, 2021 • edited Loading

Categories

Sample archive

Documentation

Unit Tests

Privacy

Changelog

References

natiiix commented Apr 14, 2021

natiiix commented Apr 19, 2021

natiiix commented Apr 20, 2021

tremes commented Apr 23, 2021

tremes commented Apr 23, 2021

openshift-ci-robot commented Apr 23, 2021

openshift-ci-robot commented Apr 23, 2021

openshift-ci-robot commented Apr 23, 2021

openshift-bot commented Apr 23, 2021

openshift-bot commented Apr 24, 2021

openshift-bot commented Apr 24, 2021

openshift-bot commented Apr 24, 2021

openshift-ci bot commented Apr 24, 2021 • edited Loading

openshift-bot commented Apr 24, 2021

openshift-bot commented Apr 24, 2021

openshift-ci-robot commented Apr 24, 2021

natiiix commented Apr 26, 2021

natiiix commented Mar 12, 2021 •

edited

Loading

openshift-ci bot commented Apr 24, 2021 •

edited

Loading