Bug 1948998: style fixes by GoLand and golangci-lint #395
Conversation
This fixes the precommit hook that was not working as expected giving some false deadcode error when checking single files.
This adds the information about the golanglint-ci version required.
openshift-ci-robot
added
the
approved
| ".dockerconfigjson": nil, | ||
| }}, | ||
| supportKey: &corev1.Secret{Data: map[string][]byte{ | ||
| supportKey: {Data: map[string][]byte{ |
There was a problem hiding this comment.
Hmm I think I like the explicit definition more.
There was a problem hiding this comment.
I don't know. I think that, once the parent object is already a corev1.Secret by doing it two times, it is just overhead. So, IMHO, the change looks good.
| if err != nil { | ||
| t.Fatal("unable to create fake netnamespace", err) | ||
| } | ||
| t.Fatal("unable to create fake netnamespace", err) |
There was a problem hiding this comment.
Lol...this was probably my work.
Serhii1011010
changed the title
openshift-ci-robot
added
bugzilla/severity-medium
|
@Sergey1011010: This pull request references Bugzilla bug 1948998, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Sergey1011010: This pull request references Bugzilla bug 1948998, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rluders, Sergey1011010 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@Sergey1011010: All pull requests linked via external trackers have merged: Bugzilla bug 1948998 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Run
golangci-lint run --skip-dirs-use-default --fix, clicked a few auto-fix buttons in GoLand, and checked it manually.Categories
Unit Tests
Some unit tests were affected, it changed code structure, but not the logic.
References
https://issues.redhat.com/browse/???
https://bugzilla.redhat.com/show_bug.cgi?id=1948998
https://access.redhat.com/solutions/???