Bug 1984047: Do not use klog.Fatal

[tremes]

klog.Fatal dumps goroutines stack traces and calls os.Exit(255). This is not desired.

Categories

• Bugfix
• Enhancement
• Backporting
• Others (CI, Infrastructure, Documentation)

Sample Archive

No new data

Documentation

No documentation update

Unit Tests

No new test

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/???
https://bugzilla.redhat.com/show_bug.cgi?id=1984047
https://access.redhat.com/solutions/???

[openshift-ci]

@tremes: This pull request references Bugzilla bug 1984047, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (dmisharo@redhat.com), skipping review request.

In response to this:

Bug 1984047: Do not use klog.Fatal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[natiiix]

After the fix mentioned by my colleague, I see no further issues. I have not tested this locally because it would be hard to simulate all the error cases, but both functions terminate the application, with the exception of the last line where Fatal was changed to Error, so there is no reason to believe that this could break IO in any way.

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natiiix, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [natiiix,tremes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@tremes: All pull requests linked via external trackers have merged:

• openshift/insights-operator#477

Bugzilla bug 1984047 has been moved to the MODIFIED state.

In response to this:

Bug 1984047: Do not use klog.Fatal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.