Bug 1987192: Set the disabled state only when the token is removed from the

[tremes]

pull-secret

The disabled state was not consistent previously. We set it in the following situations:

• token is not valid (or ingress returned 403 or 401 for some reason). Disabled was set together with UploadDegraded state, but the gathering continued.
• gathering failed multiple times in a row. Disabled was set, but it didn't have any effect. Gathering continued after some time
• token was removed from the pull-secret -> disabled was set -> gathering as well as uploading was stopped

This PR changes the disabled setting to happen only in the last situation. That's the only situation when it makes sense IMO.

Categories

• Bugfix
• Enhancement
• Backporting
• Others (CI, Infrastructure, Documentation)

Sample Archive

No update

Documentation

No update

Unit Tests

No new unit test, but it requires integ. test update https://gitlab.cee.redhat.com/ccx/insights-operator-tests/-/merge_requests/49

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/???
https://bugzilla.redhat.com/show_bug.cgi?id=???
https://access.redhat.com/solutions/???

[rluders]

/lgtm

[openshift-ci]

@tremes: This pull request references Bugzilla bug 1987192, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (dmisharo@redhat.com), skipping review request.

In response to this:

Bug 1987192: Set the disabled state only when the token is removed from the

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tremes]

/test insights-operator-e2e-tests

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[Serhii1011010]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rluders, Sergey1011010, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Sergey1011010,rluders,tremes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@tremes: All pull requests linked via external trackers have merged:

• openshift/insights-operator#478

Bugzilla bug 1987192 has been moved to the MODIFIED state.

In response to this:

Bug 1987192: Set the disabled state only when the token is removed from the

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.