Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2011822: obfuscation ovn clusters bug #515

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Bug 2011822: obfuscation ovn clusters bug #515

merged 1 commit into from
Oct 8, 2021

Conversation

Serhii1011010
Copy link
Contributor

@Serhii1011010 Serhii1011010 commented Oct 6, 2021 •
edited
Loading

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

No changes

Documentation

No changes

Unit Tests

No changes

Privacy

No new data was collected

Changelog

No

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-6055
https://bugzilla.redhat.com/show_bug.cgi?id=2011822
https://access.redhat.com/solutions/???

@openshift-ci openshift-ci bot requested review from natiiix and tremes October 6, 2021 15:25
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2021
tremes
tremes reviewed Oct 7, 2021
View reviewed changes
pkg/anonymization/anonymizer.go
// nolint:lll
// https://docs.openshift.com/container-platform/4.8/networking/ovn_kubernetes_network_provider/configuring-egress-ips-ovn.html#configuring-egress-ips-ovn
if len(hostSubnets) == 0 {
networks = append(networks, "192.168.126.0/18")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting.... :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK so right now we have only OVN and SDN right? So this should be hopefully safe now (which might change in the future if there will be some another case when there are no hostsubnets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@tremes
Copy link
Contributor

tremes commented Oct 7, 2021

I tried on 4.8 OVN cluster with enabled opt-in obfuscation and it worked good. Thank you!
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sergey1011010, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Sergey1011010,tremes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@Serhii1011010 Serhii1011010 changed the title obfuscation ovn clusters bug Bug 2009322: obfuscation ovn clusters bug Oct 7, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2021

@Sergey1011010: This pull request references Bugzilla bug 2009322, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2009322: obfuscation ovn clusters bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 7, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2021

@Sergey1011010: This pull request references Bugzilla bug 2009322, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2009322: obfuscation ovn clusters bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Serhii1011010 Serhii1011010 changed the title Bug 2009322: obfuscation ovn clusters bug Bug 2011822: obfuscation ovn clusters bug Oct 7, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. labels Oct 7, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2021

@Sergey1011010: This pull request references Bugzilla bug 2011822, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (dmisharo@redhat.com), skipping review request.

In response to this:

Bug 2011822: obfuscation ovn clusters bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 7, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4c8ea17 into openshift:master Oct 8, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 8, 2021

@Sergey1011010: All pull requests linked via external trackers have merged:

Bugzilla bug 2011822 has been moved to the MODIFIED state.

In response to this:

Bug 2011822: obfuscation ovn clusters bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Oct 15, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremes tremes tremes left review comments

@natiiix natiiix Awaiting requested review from natiiix

Assignees

@tremes tremes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Serhii1011010 @tremes @openshift-bot @openshift-merge-robot