-
Notifications
You must be signed in to change notification settings - Fork 99
Remove "InsightsOperatorPullingSCA" TP feature check #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see any issue.
/lgtm
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/label docs-approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on a provided testing cluster with an IO image built from this PR. It wasn't possible to test the alert itself due to the necessity to disable CVO to modify the IO image, but the alert part was tested before on a different cluster as a part of a different PR. When setting the scaEndpoint
to a URL that returns 404, the operator status changed to SCANotAvailable
, and then back to AsExpected
after reseting the secret entry to the default endpoint.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natiiix, rluders, tremes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label px-approved |
/label qe-approved |
@tremes: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is removing the TechPreview feature set check. IOW it means that the SCA certs will be pulled down automatically. There are also some minor enhancements in the related log messages.
This is not possible to test with cluster-bot cluster so you have to create your own cluster in AWS.
Categories
Sample Archive
No new data
Documentation
This requires OCP doc update
Unit Tests
No test update
Privacy
Yes. There are no sensitive data in the newly collected information.
Changelog
Breaking Changes
No
References
https://issues.redhat.com/browse/???
https://bugzilla.redhat.com/show_bug.cgi?id=???
https://access.redhat.com/solutions/???