HyperShift - Add required annotation to remaining manifests #585
Conversation
tremes
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tremes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Hi @csrwng so this should do the trick to get the Insights operator into a hosted cluster right? I am wondering what we will do if we later decide to install the Insights operator into control-plane of the hosted cluster. Will we have to remove this back? |
|
/retest |
1 similar comment
|
/retest |
|
Hi @tremes yes this is what's needed. And yes, if in the future we want to move it to the control plane, we would need to remove the annotations. However, the manifests can also be temporarily excluded from the CVO payload by the Hypershift control plane operator for a more immediate change, as we do with these currently: https://github.com/openshift/hypershift/blob/afe81b848cf8e4f1d58904c56ae02e380b8e8aa0/control-plane-operator/controllers/hostedcontrolplane/cvo/reconcile.go#L42-L76 |
|
@csrwng I see. Thank you. |
|
/lgtm |
|
/label px-approved |
openshift-ci
bot
added
the
px-approved
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@tremes: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
/label docs-approved |
openshift-ci
bot
added
the
docs-approved
This is adding the required annotations to the remaining manifests resource so that the Insights operator can be installed on HyperShift hosted clusters.
Categories
Sample Archive
No new data
Documentation
No docs update
Unit Tests
No new test
Privacy
Yes. There are no sensitive data in the newly collected information.
Changelog
Breaking Changes
No
References
https://issues.redhat.com/browse/CCXDEV-6636
https://bugzilla.redhat.com/show_bug.cgi?id=???
https://access.redhat.com/solutions/???