Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2065547: Gather some error messages from the kube-controller-manager containers #596

Merged

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Mar 16, 2022

Gathers logs from kube-controller-manages conainers including following messages:

  • Internal error occurred: error resolving resource
  • syncing garbage collector with updated resources from discovery

Steps to reproduce:

  1. Create a new namespace called dc-test
  2. Get the uuid from the yaml definition of the newly created namespace.
  3. Create new DeploymentConfig - you have to pass your uuid there in the ownerReference:
apiVersion: apps.openshift.io/v1
kind: DeploymentConfig
metadata:
  name: example-aaa
  namespace: dc-test
  ownerReferences:
   - apiVersion: v1
     kind: namespace
     name: dc-test
     uid: <PUT YOUR UUID>
spec:
  selector:
    app: httpd
  replicas: 3
  template:
    metadata:
      labels:
        app: httpd
    spec:
      containers:
        - name: httpd
          image: >-
            image-registry.openshift-image-registry.svc:5000/openshift/httpd:latest
          ports:
            - containerPort: 8080
  1. Stop the openshift-api with
oc patch openshiftapiservers.operator.openshift.io cluster --type merge --patch '{"spec": {"managementState": "Removed"}}'
  1. Delete the dc-test namespace.
  2. Start back the API so that you can read the logs (not sure if it's required)
oc patch openshiftapiservers.operator.openshift.io cluster --type merge --patch '{"spec": {"managementState": "Managed"}}'

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/pod/openshift-kube-controller-manager/logs/kube-controller-manager-ip-10-0-168-11.us-east-2.compute.internal/errors.log

Documentation

  • docs/gathered-data.md

Unit Tests

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-7472
https://issues.redhat.com/browse/INSIGHTOCP-598
https://bugzilla.redhat.com/show_bug.cgi?id=2065547
https://access.redhat.com/solutions/???

@tremes
Copy link
Contributor Author

tremes commented Mar 16, 2022

@jholecek-rh please check

@openshift-ci openshift-ci bot requested review from mfojtik and rluders March 16, 2022 15:04
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2022
Copy link
Contributor

@natiiix natiiix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code fine, and I tested the modified IO on a testing cluster. After performing the described steps, I got a log file with three syncing garbage collector with updated resources from discovery (attempt 1): added: ... errors in the IO archive, so it seems to work as it's supposed to.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natiiix, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link

openshift-ci bot commented Mar 18, 2022

@tremes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tremes tremes changed the title Gather some error messages from the kube-controller-manager containers Bug 2065547: Gather some error messages from the kube-controller-manager containers Mar 18, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 18, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 18, 2022

@tremes: This pull request references Bugzilla bug 2065547, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @JoaoFula

In response to this:

Bug 2065547: Gather some error messages from the kube-controller-manager containers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from JoaoFula March 18, 2022 07:38
@openshift-merge-robot openshift-merge-robot merged commit acdcfc6 into openshift:master Mar 18, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 18, 2022

@tremes: All pull requests linked via external trackers have merged:

Bugzilla bug 2065547 has been moved to the MODIFIED state.

In response to this:

Bug 2065547: Gather some error messages from the kube-controller-manager containers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes
Copy link
Contributor Author

tremes commented Mar 18, 2022

/cherry-pick release-4.10

@openshift-cherrypick-robot

@tremes: new pull request created: #598

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants