save version of gathering rules in metadata #601
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Sergey1011010 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Serhii1011010
force-pushed
the
save-version-of-gathering-rules-in-metadata
branch
from
8cdb41f to
4ef58c4
Compare
| klog.Infof( | ||
| "trying to use cached gathering config containing %v gathering rules and version %v", | ||
| len(g.gatheringRules.Rules), g.gatheringRules.Version, | ||
| ) |
There was a problem hiding this comment.
This is only idea. I am thinking if it would be slightly more clear to move the rest of the GetGatheringFunctions to some new function (e.g createGatheringFunctions) and return here with the function call return createGatheringFunctions(g.gatheringRules) and remove the else and simply return return createGatheringFunctions(newGatheringRules) then. And perhaps return nil in https://github.com/openshift/insights-operator/pull/601/files#diff-57e9d48447e382f53bafe213301e653fd5989c354c9d751e7f6386be25459e89R169.
|
I didn't trigger any conditional gatherer with this update but I reviewed it and the changes look reasonable and good. Thank you! |
|
/test insights-operator-e2e-tests |
1 similar comment
|
/test insights-operator-e2e-tests |
|
/label docs-approved |
openshift-ci
bot
added
the
docs-approved
|
/test insights-operator-e2e-tests |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/label qe-approved |
|
/label px-approved |
openshift-ci
bot
added
the
px-approved
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@Sergey1011010: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Categories
Sample Archive
insights-operator/conditional-gatherer-rules.jsonDocumentation
No
Unit Tests
pkg/gatherers/conditional/parsing_test.goPrivacy
No new data was collected
Changelog
No
Breaking Changes
Yes, changed the structure of
insights-operator/conditional-gatherer-rules.jsonReferences
https://issues.redhat.com/browse/CCXDEV-7488
https://bugzilla.redhat.com/show_bug.cgi?id=???
https://access.redhat.com/solutions/???