save conditional gatherer endpoint and firing alerts in the metadata #620
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Sergey1011010 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
| "firing_alerts": [ | ||
| "AlertmanagerClusterDown", | ||
| "TargetDown", | ||
| "Watchdog" |
There was a problem hiding this comment.
Isn't that redundant information,please? I mean we have was_triggered flag, which implies that an alert was firing right?
There was a problem hiding this comment.
It can be helpful for debugging and also could be used in the integration tests later
There was a problem hiding this comment.
Having something helpful for debugging and in the integration tests doesn't mean we have to add it to the archive ....at least for me :-P Anyway, it's probably not a big deal (although once something is in the archive then it's pretty difficult to remove it), I am just saying that I think the information is already there.
There was a problem hiding this comment.
Well, it's not, the condition can be more complicated than just an alert (rn it can also include cluster version, but later probably more things)
There was a problem hiding this comment.
It's not too important tho, we could delete it if you want
There was a problem hiding this comment.
Good point with the conditions potentially being more complicated, but we don't have any at the moment AFAIK so I wouldn't add it now.
There was a problem hiding this comment.
Thanks so we need to change the sample archive as well right.
|
/label docs-approved |
openshift-ci
bot
added
the
docs-approved
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
I didn't test with any firing alert, but it looks good to me. Thanks. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@Sergey1011010: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/label px-approved |
openshift-ci
bot
added
the
px-approved
Categories
Sample Archive
docs/insights-archive-sample/insights-operator/conditional-gatherer-rules.jsonDocumentation
No changes
Unit Tests
path/to/file_test.goPrivacy
No new data was collected
Changelog
No
Breaking Changes
No
References
https://issues.redhat.com/browse/???
https://bugzilla.redhat.com/show_bug.cgi?id=???
https://access.redhat.com/solutions/???