Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make cluster version condition more flexible #633

Conversation

Serhii1011010
Copy link
Contributor

Fixes a bug with conditional gatherer integration tests

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

No changes

Documentation

No changes

Unit Tests

  • pkg/gatherers/conditional/conditional_gatherer_test.go
  • pkg/gatherers/conditional/conditions_test.go

Privacy

No new data was collected

Changelog

No

Breaking Changes

No

References

https://issues.redhat.com/browse/???
https://bugzilla.redhat.com/show_bug.cgi?id=???
https://access.redhat.com/solutions/???

@openshift-ci openshift-ci bot requested review from mfojtik and natiiix June 2, 2022 13:54
@openshift-ci
Copy link

openshift-ci bot commented Jun 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sergey1011010

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2022
@Serhii1011010 Serhii1011010 force-pushed the make-cluster-version-condition-more-flexible branch from 08f1d72 to 06df81b Compare June 2, 2022 14:01
@tremes
Copy link
Contributor

tremes commented Jun 6, 2022

I reviewed the changes, but didn't manually test any conditional gatherer.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2022
@Serhii1011010
Copy link
Contributor Author

/retest-required

@JoaoFula
Copy link
Contributor

JoaoFula commented Jun 9, 2022

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jun 9, 2022
@tremes
Copy link
Contributor

tremes commented Jun 9, 2022

This is a minor update (neither a feature nor a bug). I am adding the labels myself.
/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Jun 9, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 062a9c7 and 8 for PR HEAD b23ea94 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 062a9c7 and 7 for PR HEAD b23ea94 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 062a9c7 and 6 for PR HEAD b23ea94 in total

@tremes
Copy link
Contributor

tremes commented Jun 10, 2022

/test e2e-agnostic-upgrade

@Serhii1011010
Copy link
Contributor Author

/retest-required

@tremes
Copy link
Contributor

tremes commented Jun 13, 2022

/test e2e-agnostic-upgrade

@openshift-ci
Copy link

openshift-ci bot commented Jun 13, 2022

@Sergey1011010: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit a18939a into openshift:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants