Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openshift-machine-api warning events gatherer #658

Merged
merged 22 commits into from
Aug 31, 2022

Conversation

rhrmo
Copy link
Contributor

@rhrmo rhrmo commented Aug 16, 2022

This PR implements new gatherer for gathering "non-standard" or "abnormal" events from the "openshift-machine-api" namespace.

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/events/openshift-machine-api.json

Documentation

  • docs/gathered-data.md

Unit Tests

  • pkg/gatherers/clusterconfig/openshift_machine_api_events_test.go
  • pkg/gatherers/clusterconfig/events_filtering_test.go

Privacy

There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-8389

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 16, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 16, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhrmo rhrmo marked this pull request as ready for review August 24, 2022 06:33
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 24, 2022
@openshift-ci openshift-ci bot requested review from rluders and tremes August 24, 2022 06:33
@openshift-ci
Copy link

openshift-ci bot commented Aug 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Megonasayit, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2022
@tremes
Copy link
Contributor

tremes commented Aug 25, 2022

/retest

@sferich888
Copy link

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Aug 25, 2022
@xJustin
Copy link
Contributor

xJustin commented Aug 26, 2022

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Aug 26, 2022
@JoaoFula
Copy link
Contributor

label /qe-approved

@JoaoFula
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 30, 2022
@rhrmo rhrmo force-pushed the development branch 2 times, most recently from c396a68 to 6f45393 Compare August 30, 2022 14:02
@rhrmo
Copy link
Contributor Author

rhrmo commented Aug 31, 2022

/retest

@tremes
Copy link
Contributor

tremes commented Aug 31, 2022

I reviewed it several times. Good job! Thank you.
/lgtm

@tremes
Copy link
Contributor

tremes commented Aug 31, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 31, 2022

@Megonasayit: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 9e528ed into openshift:master Aug 31, 2022
@rhrmo rhrmo deleted the development branch September 1, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants