-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openshift-machine-api warning events gatherer #658
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Megonasayit, tremes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/label px-approved |
/label docs-approved |
label /qe-approved |
/label qe-approved |
c396a68
to
6f45393
Compare
/retest |
pkg/gatherers/clusterconfig/openshift_machine_api_events_test.go
Outdated
Show resolved
Hide resolved
pkg/gatherers/clusterconfig/openshift_machine_api_events_test.go
Outdated
Show resolved
Hide resolved
pkg/gatherers/clusterconfig/openshift_machine_api_events_test.go
Outdated
Show resolved
Hide resolved
I reviewed it several times. Good job! Thank you. |
/lgtm |
@Megonasayit: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR implements new gatherer for gathering "non-standard" or "abnormal" events from the "openshift-machine-api" namespace.
Categories
Sample Archive
docs/insights-archive-sample/events/openshift-machine-api.json
Documentation
docs/gathered-data.md
Unit Tests
pkg/gatherers/clusterconfig/openshift_machine_api_events_test.go
pkg/gatherers/clusterconfig/events_filtering_test.go
Privacy
There are no sensitive data in the newly collected information.
Changelog
Breaking Changes
No
References
https://issues.redhat.com/browse/CCXDEV-8389