Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.11] OCPBUGS-6834: feat(recent_metrics) adds openshift_apps_deploymentconfigs_strategy_total #739

Merged
merged 1 commit into from
Feb 23, 2023
Merged

[release-4.11] OCPBUGS-6834: feat(recent_metrics) adds openshift_apps_deploymentconfigs_strategy_total #739

merged 1 commit into from
Feb 23, 2023

Conversation

rluders
Copy link
Contributor

@rluders rluders commented Feb 20, 2023

This PR backports #726

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/metrics (updated)

Documentation

  • docs/gathered-data.md

Unit Tests

None.

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/OCPBUGS-6834

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 20, 2023
@openshift-ci-robot
Copy link
Contributor

@rluders: This pull request references Jira Issue OCPBUGS-6834, which is invalid:

  • expected dependent Jira Issue OCPBUGS-6833 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR backports #726

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/metrics (updated)

Documentation

  • docs/gathered-data.md

Unit Tests

None.

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/OCPBUGS-6834

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 20, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 20, 2023

@rluders: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.11] OCPBUGS-6834: feat(recent_metrics) adds openshift_apps_deploymentconfigs_strategy_total

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Feb 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rluders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2023
OCPBUGS-6832: feat(recent_metrics) adds openshift_apps_deploymentconf…
135dcfb 
…igs_strategy_total (openshift#726)

* feat(recent_metrics) adds openshift_apps_deploymentconfigs_strategy_total

* chore(docs): update gathered data

* fix(status/controller): fix status error for UnknownError
@rluders rluders force-pushed the feat/release-4.11--deploymentconfig-strategy-total branch from e955e94 to 135dcfb Compare February 20, 2023 13:24
@rluders
Copy link
Contributor Author

rluders commented Feb 22, 2023

/override ci/prow/lint

@rluders
Copy link
Contributor Author

rluders commented Feb 22, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 22, 2023
@openshift-ci-robot
Copy link
Contributor

@rluders: This pull request references Jira Issue OCPBUGS-6834, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.11.z) matches configured target version for branch (4.11.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-6833 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-6833 targets the "4.12.z" version, which is one of the valid target versions: 4.12.0, 4.12.z
  • bug has dependents

Requesting review from QA contact:
/cc @JoaoFula

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 22, 2023
@openshift-ci openshift-ci bot requested a review from JoaoFula February 22, 2023 20:34
@openshift-ci
Copy link

openshift-ci bot commented Feb 22, 2023

@rluders: Overrode contexts on behalf of rluders: ci/prow/lint

In response to this:

/override ci/prow/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoaoFula
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 23, 2023
@JoaoFula
Copy link
Contributor

/retest

1 similar comment
@JoaoFula
Copy link
Contributor

/retest

@openshift-ci
Copy link

openshift-ci bot commented Feb 23, 2023

@rluders: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tremes
Copy link
Contributor

tremes commented Feb 23, 2023

Backport. Works and looks good.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2023
@tremes
Copy link
Contributor

tremes commented Feb 23, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 23, 2023
@openshift-merge-robot openshift-merge-robot merged commit cdd3b91 into openshift:release-4.11 Feb 23, 2023
@openshift-ci-robot
Copy link
Contributor

@rluders: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-6834 has been moved to the MODIFIED state.

In response to this:

This PR backports #726

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/metrics (updated)

Documentation

  • docs/gathered-data.md

Unit Tests

None.

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/OCPBUGS-6834

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@tisnik tisnik Awaiting requested review from tisnik

@JoaoFula JoaoFula Awaiting requested review from JoaoFula

Assignees

@tremes tremes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rluders @openshift-ci-robot @JoaoFula @tremes @openshift-merge-robot