-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: renaming gather files #768
chore: renaming gather files #768
Conversation
/retest |
1 similar comment
/retest |
This could backtrack to these Jira issues, as it partially solves them:
Also, could we take advantage on this PR and sort |
@ncaak sorting the gathetingFunctions is actually a good idea. I'll update the PR. |
6ecea2c
to
2af6808
Compare
I'm changing it for the draft, 'cause I'll include the unit tests for:
|
2af6808
to
020d568
Compare
e79ee3d
to
0629243
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
0629243
to
665bfb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/override ci/prow/lint |
@rluders: Overrode contexts on behalf of rluders: ci/prow/lint In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
…r_validating_webhook_configurations
665bfb4
to
fd44e09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncaak, rluders The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/lint |
@rluders: Overrode contexts on behalf of rluders: ci/prow/lint In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/label qe-approved |
/retest |
@rluders: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
* chore(clusterconfig): rename authentications to gather_authentication * chore(clusterconfig): rename ceph_cluster to gather_cepth_cluster * chore(clusterconfig): rename certificate_signing_requests to gather_certificate_signing_requests * chore(clusterconfig): rename config_maps to gather_config_maps * chore(clusterconfig): rename container_images to gather_container_images * chore(clusterconfig): rename container_runtime_configs to gather_container_runtime_configs * chore(clusterconfig): rename cost_management_metrics_configs to gather_cost_management_metrics_configs * chore(clusterconfig): rename custom_resource_definitions to gather_custom_resource_definitions * chore(clusterconfig): rename dvo_metrics to gather_dvo_metrics * chore(clusterconfig): rename feature_gates to gather_feature_gates * chore(clusterconfig): rename host_subnets to gather_host_subnets * chore(clusterconfig): rename image to gather_cluster_image * chore(clusterconfig): rename image_pruners to gather_image_pruners * chore(clusterconfig): rename image_registries to gather_cluster_image_registries * chore(clusterconfig): rename install_plans to gather_install_plans * chore(clusterconfig): rename jaeger_cr to gather_jaeger_cr * chore(clusterconfig): rename machine_autoscalers to gather_machine_autoscalers * chore(clusterconfig): rename machine_config_pools to gather_machine_config_pools * chore(clusterconfig): rename machine_configs to gather_machine_configs * chore(clusterconfig): rename machine_healthchecks to gather_machine_health_check * chore(clusterconfig): rename machine_sets to gather_machine_sets * chore(clusterconfig): rename machines to gather_machines * chore(clusterconfig): rename mutatingwebhookconfigurations to gather_mutating_webhook_configurations * chore(clusterconfig): rename namespaces_with_overlapping_uids to gather_namespaces_with_overlapping_uids * chore(clusterconfig): rename netnamespace to gather_net_namespace * chore(clusterconfig): rename node_logs to gather_node_logs * chore(clusterconfig): rename olm_operators to gather_olm_operators * chore(clusterconfig): rename openshift_logging to gather_openshift_logging * chore(clusterconfig): rename openshift_machine_api_events to gather_openshift_machine_api_events * chore(clusterconfig): rename operators to gather_cluster_operators * chore(clusterconfig): rename operators_pods_and_events to gather_cluster_operator_pods_and_events * chore(clusterconfig): rename pod_disruption_budgets to gather_pod_disruption_budgets * chore(clusterconfig): rename pod_network_connectivity_checks to gather_pod_network_connectivity_checks * chore(clusterconfig): rename sap_config to gather_sap_config * chore(clusterconfig): rename sap_datahubs to gather_sap_datahubs * chore(clusterconfig): rename sap_pods to gather_sap_pods * chore(clusterconfig): rename scheduler to gather_schedulers * chore(clusterconfig): rename service_accounts to gather_service_accounts * chore(clusterconfig): rename storage_cluster to gather_storage_cluster * chore(clusterconfig): rename support_secret to gather_support_secret * chore(clusterconfig): rename tsdb_status to gather_prometheus_tsdb_status * chore(clusterconfig): rename validatingwebhookconfigurations to gather_validating_webhook_configurations * test(clusterconfig): adjusting method names * chore(workloads): rename workload_info to gather_workload_info * docs(gathered-data): update gathered-data docs * refactor: sort the gatherers for configcluster * test(clusterconfig): add tests for gather_cluster_feature_gates * test(clusterconfig): add tests for gather_cluster_authentication * test(clusterconfig): adds unit test for gather_prometheus_tsdb_status * fix: adding lost gatherers on merge
This PR renames the gather files to match gather method and prefix it with gather.
Categories
Sample Archive
N/A
Documentation
docs/gathered-data.md
Unit Tests
It also renames the test files to match the gather file.
Privacy
Yes. There are no sensitive data in the newly collected information.
Changelog
Breaking Changes
No
References
https://issues.redhat.com/browse/CCXDEV-10109
https://issues.redhat.com/browse/CCXDEV-10104
https://issues.redhat.com/browse/CCXDEV-10103
https://issues.redhat.com/browse/CCXDEV-10129