-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-17428: workload info gatherer, add external image repo #811
OCPBUGS-17428: workload info gatherer, add external image repo #811
Conversation
/test |
Skipping CI for Draft Pull Request. |
@ncaak: This pull request references CCXDEV-11505 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test required |
@ncaak: The
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test all |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncaak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ee04e7a
to
dea7360
Compare
/test all |
/test e2e-metal-ipi-ovn-ipv6 |
/test e2e-gcp-ovn-techpreview |
1 similar comment
/test e2e-gcp-ovn-techpreview |
I didn't try it, but looks good. |
@ncaak: This pull request references Jira Issue OCPBUGS-17428, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@ncaak: This pull request references Jira Issue OCPBUGS-17428, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@ncaak: This pull request references Jira Issue OCPBUGS-17428, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-gcp-ovn-techpreview |
/override e2e-gcp-ovn-techpreview |
/override ci/prow/e2e-gcp-ovn-techpreview |
@ncaak: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ncaak: Overrode contexts on behalf of ncaak: ci/prow/e2e-gcp-ovn-techpreview In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label qe-approved |
Update of existing gatherer. |
@tremes: Overrode contexts on behalf of tremes: ci/prow/e2e-gcp-ovn-techpreview, ci/prow/e2e-metal-ipi-ovn-ipv6 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ncaak: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@ncaak: Jira Issue OCPBUGS-17428: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-17428 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-4.13 |
@ncaak: new pull request created: #816 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-4.12 |
@ncaak: #811 failed to apply on top of branch "release-4.12":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…hift#811) * Add new property to save image repository url * Add unit tests for repository image handling * Add new function to get only external repos urls * Update last change in documentation * Add sample data * Hash image information to match gatherer functionality * Fix sample with hashed data (from output)
This PR implements a new data enhancement to Workload info gatherer to add image repository to the archive. The repository image is only collected if it's from outside of Red Hat domain.
Categories
Sample Archive
docs/insights-archive-sample/config/workload_info.json
Documentation
docs/gathered-data.md
Unit Tests
pkg/gatherers/workloads/gather_workloads_info_test.go
Privacy
Yes. There are no sensitive data in the newly collected information.
Changelog
No
Breaking Changes
No
References
https://issues.redhat.com/browse/CCXDEV-11505
https://issues.redhat.com/browse/OCPBUGS-17428