Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-17428: workload info gatherer, add external image repo #811

Conversation

ncaak
Copy link
Contributor

@ncaak ncaak commented Jul 31, 2023

This PR implements a new data enhancement to Workload info gatherer to add image repository to the archive. The repository image is only collected if it's from outside of Red Hat domain.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/workload_info.json

Documentation

  • docs/gathered-data.md

Unit Tests

  • pkg/gatherers/workloads/gather_workloads_info_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

No

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-11505
https://issues.redhat.com/browse/OCPBUGS-17428

@ncaak
Copy link
Contributor Author

ncaak commented Jul 31, 2023

/test

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 31, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ncaak ncaak changed the title Ccxdev 11505: workload info gatherer, add external image repo CCXDEV-11505: workload info gatherer, add external image repo Jul 31, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 31, 2023

@ncaak: This pull request references CCXDEV-11505 which is a valid jira issue.

In response to this:

This PR implements a new data enhancement to Workload info gatherer to add image repository to the archive. The repository image is only collected if it's from outside of Red Hat domain.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/workload_info.json

Documentation

  • docs/gathered-data.md

Unit Tests

  • pkg/gatherers/workloads/gather_workloads_info_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

No

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-11505

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 31, 2023
@ncaak
Copy link
Contributor Author

ncaak commented Jul 31, 2023

/test required

@openshift-ci
Copy link

openshift-ci bot commented Jul 31, 2023

@ncaak: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test e2e
  • /test e2e-agnostic-upgrade
  • /test e2e-metal-ipi-ovn-ipv6
  • /test images
  • /test insights-operator-e2e-tests
  • /test lint
  • /test unit

The following commands are available to trigger optional jobs:

  • /test e2e-gcp-ovn-techpreview

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ncaak
Copy link
Contributor Author

ncaak commented Jul 31, 2023

/test all

@openshift-ci
Copy link

openshift-ci bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2023
@ncaak ncaak force-pushed the CCXDEV-11505/workload-info-image-repo branch from ee04e7a to dea7360 Compare August 4, 2023 10:21
@ncaak
Copy link
Contributor Author

ncaak commented Aug 4, 2023

/test all

@ncaak ncaak marked this pull request as ready for review August 7, 2023 16:32
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2023
@openshift-ci openshift-ci bot requested review from rluders and tremes August 7, 2023 16:33
@ncaak
Copy link
Contributor Author

ncaak commented Aug 8, 2023

/test e2e-metal-ipi-ovn-ipv6

@ncaak
Copy link
Contributor Author

ncaak commented Aug 8, 2023

/test e2e-gcp-ovn-techpreview

1 similar comment
@ncaak
Copy link
Contributor Author

ncaak commented Aug 8, 2023

/test e2e-gcp-ovn-techpreview

@tremes
Copy link
Contributor

tremes commented Aug 9, 2023

@ncaak I guess we first need to merge #812 for the testsuite to pass....sorry for the incovenience

@tremes
Copy link
Contributor

tremes commented Aug 10, 2023

I didn't try it, but looks good.
/lgtm

@openshift-ci-robot
Copy link
Contributor

@ncaak: This pull request references Jira Issue OCPBUGS-17428, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.15.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR implements a new data enhancement to Workload info gatherer to add image repository to the archive. The repository image is only collected if it's from outside of Red Hat domain.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/workload_info.json

Documentation

  • docs/gathered-data.md

Unit Tests

  • pkg/gatherers/workloads/gather_workloads_info_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

No

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-11505
https://issues.redhat.com/browse/OCPBUGS-17428

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ncaak
Copy link
Contributor Author

ncaak commented Aug 10, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@ncaak: This pull request references Jira Issue OCPBUGS-17428, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.15.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ncaak
Copy link
Contributor Author

ncaak commented Aug 10, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 10, 2023
@openshift-ci-robot
Copy link
Contributor

@ncaak: This pull request references Jira Issue OCPBUGS-17428, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @JoaoFula

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from JoaoFula August 10, 2023 07:50
@ncaak
Copy link
Contributor Author

ncaak commented Aug 10, 2023

/test e2e-gcp-ovn-techpreview

@ncaak
Copy link
Contributor Author

ncaak commented Aug 10, 2023

/override e2e-gcp-ovn-techpreview

@ncaak
Copy link
Contributor Author

ncaak commented Aug 10, 2023

/override ci/prow/e2e-gcp-ovn-techpreview

@openshift-ci
Copy link

openshift-ci bot commented Aug 10, 2023

@ncaak: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-gcp-ovn-techpreview

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e
  • ci/prow/e2e-agnostic-upgrade
  • ci/prow/e2e-gcp-ovn-techpreview
  • ci/prow/e2e-metal-ipi-ovn-ipv6
  • ci/prow/images
  • ci/prow/insights-operator-e2e-tests
  • ci/prow/lint
  • ci/prow/unit
  • pull-ci-openshift-insights-operator-master-e2e
  • pull-ci-openshift-insights-operator-master-e2e-agnostic-upgrade
  • pull-ci-openshift-insights-operator-master-e2e-gcp-ovn-techpreview
  • pull-ci-openshift-insights-operator-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-insights-operator-master-images
  • pull-ci-openshift-insights-operator-master-insights-operator-e2e-tests
  • pull-ci-openshift-insights-operator-master-lint
  • pull-ci-openshift-insights-operator-master-unit
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override e2e-gcp-ovn-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 10, 2023

@ncaak: Overrode contexts on behalf of ncaak: ci/prow/e2e-gcp-ovn-techpreview

In response to this:

/override ci/prow/e2e-gcp-ovn-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes
Copy link
Contributor

tremes commented Aug 10, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 10, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4efc924 and 2 for PR HEAD eb27786 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d64d834 and 1 for PR HEAD eb27786 in total

@tremes
Copy link
Contributor

tremes commented Aug 11, 2023

Update of existing gatherer.
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-gcp-ovn-techpreview

@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2023

@tremes: Overrode contexts on behalf of tremes: ci/prow/e2e-gcp-ovn-techpreview, ci/prow/e2e-metal-ipi-ovn-ipv6

In response to this:

Update of existing gatherer.
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-gcp-ovn-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2023

@ncaak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit f936f69 into openshift:master Aug 11, 2023
@openshift-ci-robot
Copy link
Contributor

@ncaak: Jira Issue OCPBUGS-17428: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17428 has been moved to the MODIFIED state.

In response to this:

This PR implements a new data enhancement to Workload info gatherer to add image repository to the archive. The repository image is only collected if it's from outside of Red Hat domain.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/workload_info.json

Documentation

  • docs/gathered-data.md

Unit Tests

  • pkg/gatherers/workloads/gather_workloads_info_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

No

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-11505
https://issues.redhat.com/browse/OCPBUGS-17428

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ncaak
Copy link
Contributor Author

ncaak commented Aug 11, 2023

/cherrypick release-4.13

@openshift-cherrypick-robot

@ncaak: new pull request created: #816

In response to this:

/cherrypick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ncaak
Copy link
Contributor Author

ncaak commented Sep 14, 2023

/cherrypick release-4.12

@openshift-cherrypick-robot

@ncaak: #811 failed to apply on top of branch "release-4.12":

Applying: Add new property to save image repository url
Applying: Add unit tests for repository image handling
Using index info to reconstruct a base tree...
A	pkg/gatherers/workloads/gather_workloads_info_test.go
Falling back to patching base and 3-way merge...
Applying: Add new function to get only external repos urls
Using index info to reconstruct a base tree...
A	pkg/gatherers/workloads/gather_workloads_info.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/gatherers/workloads/workloads_info.go
CONFLICT (content): Merge conflict in pkg/gatherers/workloads/workloads_info.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 Add new function to get only external repos urls
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JoaoFula pushed a commit to JoaoFula/insights-operator that referenced this pull request Jan 23, 2024
…hift#811)

* Add new property to save image repository url

* Add unit tests for repository image handling

* Add new function to get only external repos urls

* Update last change in documentation

* Add sample data

* Hash image information to match gatherer functionality

* Fix sample with hashed data (from output)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants