Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-23962: adds helm information gather #868

Merged
merged 14 commits into from
Dec 2, 2023
Merged

OCPBUGS-23962: adds helm information gather #868

merged 14 commits into from
Dec 2, 2023

Conversation

rluders
Copy link
Contributor

@rluders rluders commented Nov 16, 2023 •
edited
Loading

This PR implements a new data enhancement to collect Helm Chart statistics from the cluster.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/helmchart_info.json

Documentation

  • docs/gathered-data.md (updated)

Unit Tests

  • pkg/gatherers/workloads/gather_helm_info_test.go
  • pkg/gatherers/workloads/gather_workloads_info_test.go (updated)
  • pkg/gatherers/workloads/types_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-12266

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 16, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 16, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2023
@rluders rluders force-pushed the feat/gather-helm-statistic branch from ffccb10 to ea300d0 Compare November 23, 2023 14:44
@rluders rluders marked this pull request as ready for review November 27, 2023 07:56
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 27, 2023
@openshift-ci openshift-ci bot requested review from ncaak and rhrmo November 27, 2023 07:57
@rluders rluders marked this pull request as draft November 27, 2023 07:57
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 27, 2023
@rluders
Copy link
Contributor Author

rluders commented Nov 27, 2023

/test

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 27, 2023

@rluders: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test e2e
  • /test e2e-agnostic-upgrade
  • /test e2e-gcp-ovn-techpreview
  • /test images
  • /test insights-operator-e2e-tests
  • /test lint
  • /test unit

The following commands are available to trigger optional jobs:

  • /test e2e-metal-ipi-ovn-ipv6

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rluders
Copy link
Contributor Author

rluders commented Nov 27, 2023

/test all

@rluders rluders marked this pull request as ready for review November 27, 2023 08:41
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 27, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak, rluders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rluders
Copy link
Contributor Author

rluders commented Nov 29, 2023

/test ci/prow/insights-operator-e2e-tests

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 29, 2023

@rluders: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e
  • /test e2e-agnostic-upgrade
  • /test e2e-gcp-ovn-techpreview
  • /test images
  • /test insights-operator-e2e-tests
  • /test lint
  • /test unit

The following commands are available to trigger optional jobs:

  • /test e2e-metal-ipi-ovn-ipv6

Use /test all to run all jobs.

In response to this:

/test ci/prow/insights-operator-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rluders
Copy link
Contributor Author

rluders commented Nov 29, 2023

/test insights-operator-e2e-tests

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD f440fa0 and 2 for PR HEAD c581bc9 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4d4542e and 1 for PR HEAD c581bc9 in total

@tremes
Copy link
Contributor

tremes commented Dec 1, 2023

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9b91ed4 and 0 for PR HEAD c581bc9 in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision c581bc9 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2023
@rluders
Copy link
Contributor Author

rluders commented Dec 1, 2023

/retest

@rluders
Copy link
Contributor Author

rluders commented Dec 1, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 2, 2023

@rluders: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0371ec5 into openshift:master Dec 2, 2023
@openshift-ci-robot
Copy link
Contributor

@rluders: Jira Issue OCPBUGS-23962: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-23962 has been moved to the MODIFIED state.

In response to this:

This PR implements a new data enhancement to collect Helm Chart statistics from the cluster.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/helmchart_info.json

Documentation

  • docs/gathered-data.md (updated)

Unit Tests

  • pkg/gatherers/workloads/gather_helm_info_test.go
  • pkg/gatherers/workloads/gather_workloads_info_test.go (updated)
  • pkg/gatherers/workloads/types_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-12266

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-insights-operator-container-v4.15.0-202312020449.p0.g0371ec5.assembly.stream for distgit ose-insights-operator.
All builds following this will include this PR.

rluders pushed a commit to rluders/insights-operator that referenced this pull request Dec 5, 2023
OCPBUGS-23962: adds helm information gather (openshift#868)
ea19b32 
* feat: gather helm information

* feat(gather/hemlchart_info): add resource counter

* docs: adds helmchart_info sample data

* test: adds some unit test for helmchart_gather

* test: expanding gather_helm_info tests

* feat: adding helmchart gatherer

* docs: update gathered-data

* Revert "feat: adding helmchart gatherer"

This reverts commit e57a5c1.

* refactor: revert helmcharts gatherer

* style: fix lint errors

* refactor(helm_info): remove if for label checking

* refactor(gather_info): unexpose labelChartNameKey const

* fix: wrong log message

* test(helm_gather_info): invalid resources
@rluders rluders mentioned this pull request Dec 5, 2023
Merged
5 tasks
rluders pushed a commit to rluders/insights-operator that referenced this pull request Dec 7, 2023
OCPBUGS-23962: adds helm information gather (openshift#868)
8e67832 
* feat: gather helm information

* feat(gather/hemlchart_info): add resource counter

* docs: adds helmchart_info sample data

* test: adds some unit test for helmchart_gather

* test: expanding gather_helm_info tests

* feat: adding helmchart gatherer

* docs: update gathered-data

* Revert "feat: adding helmchart gatherer"

This reverts commit e57a5c1.

* refactor: revert helmcharts gatherer

* style: fix lint errors

* refactor(helm_info): remove if for label checking

* refactor(gather_info): unexpose labelChartNameKey const

* fix: wrong log message

* test(helm_gather_info): invalid resources
@rluders rluders mentioned this pull request Dec 7, 2023
Merged
5 tasks
openshift-merge-bot bot pushed a commit that referenced this pull request Dec 8, 2023
OCPBUGS-23962: adds helm information gather (#868) (#877)
b90c2d6 
* feat: gather helm information

* feat(gather/hemlchart_info): add resource counter

* docs: adds helmchart_info sample data

* test: adds some unit test for helmchart_gather

* test: expanding gather_helm_info tests

* feat: adding helmchart gatherer

* docs: update gathered-data

* Revert "feat: adding helmchart gatherer"

This reverts commit e57a5c1.

* refactor: revert helmcharts gatherer

* style: fix lint errors

* refactor(helm_info): remove if for label checking

* refactor(gather_info): unexpose labelChartNameKey const

* fix: wrong log message

* test(helm_gather_info): invalid resources
@rluders rluders mentioned this pull request Dec 14, 2023
Closed
5 tasks
openshift-merge-bot bot pushed a commit that referenced this pull request Dec 18, 2023
OCPBUGS-23962: adds helm information gather (#868) (#883)
a5cb14c 
* feat: gather helm information

* feat(gather/hemlchart_info): add resource counter

* docs: adds helmchart_info sample data

* test: adds some unit test for helmchart_gather

* test: expanding gather_helm_info tests

* feat: adding helmchart gatherer

* docs: update gathered-data

* Revert "feat: adding helmchart gatherer"

This reverts commit e57a5c1.

* refactor: revert helmcharts gatherer

* style: fix lint errors

* refactor(helm_info): remove if for label checking

* refactor(gather_info): unexpose labelChartNameKey const

* fix: wrong log message

* test(helm_gather_info): invalid resources
@rluders rluders mentioned this pull request Dec 20, 2023
Merged
5 tasks
rluders pushed a commit to rluders/insights-operator that referenced this pull request Jan 2, 2024
OCPBUGS-23962: adds helm information gather (openshift#868)
2aa348a 
* feat: gather helm information

* feat(gather/hemlchart_info): add resource counter

* docs: adds helmchart_info sample data

* test: adds some unit test for helmchart_gather

* test: expanding gather_helm_info tests

* feat: adding helmchart gatherer

* docs: update gathered-data

* Revert "feat: adding helmchart gatherer"

This reverts commit e57a5c1.

* refactor: revert helmcharts gatherer

* style: fix lint errors

* refactor(helm_info): remove if for label checking

* refactor(gather_info): unexpose labelChartNameKey const

* fix: wrong log message

* test(helm_gather_info): invalid resources
@rluders rluders mentioned this pull request Jan 2, 2024
Merged
5 tasks
JoaoFula pushed a commit to JoaoFula/insights-operator that referenced this pull request Jan 23, 2024
@JoaoFula
OCPBUGS-23962: adds helm information gather (openshift#868)
0d831a8 
* feat: gather helm information

* feat(gather/hemlchart_info): add resource counter

* docs: adds helmchart_info sample data

* test: adds some unit test for helmchart_gather

* test: expanding gather_helm_info tests

* feat: adding helmchart gatherer

* docs: update gathered-data

* Revert "feat: adding helmchart gatherer"

This reverts commit e57a5c1.

* refactor: revert helmcharts gatherer

* style: fix lint errors

* refactor(helm_info): remove if for label checking

* refactor(gather_info): unexpose labelChartNameKey const

* fix: wrong log message

* test(helm_gather_info): invalid resources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncaak ncaak ncaak approved these changes

@rhrmo rhrmo Awaiting requested review from rhrmo

@JoaoFula JoaoFula Awaiting requested review from JoaoFula

@tremes tremes Awaiting requested review from tremes

Assignees

@ncaak ncaak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rluders @openshift-ci-robot @tremes @openshift-bot @ncaak