Skip to content

NO-JIRA: Adding insights-config configuration description to arch.md #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

JoaoFula
Copy link
Contributor

@JoaoFula JoaoFula commented Jan 3, 2024

No testing needed.

Just a docs change.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 3, 2024
@openshift-ci-robot
Copy link
Contributor

@JoaoFula: This pull request explicitly references no jira issue.

In response to this:

No testing needed.

Just a docs change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from ncaak and rluders January 3, 2024 16:29
docs/arch.md Outdated
- `clusterTransferEndpoint` - the endpoint for checking & download cluster transfer data (updated `pull-secret` data). Overwritten by `clusterTransfer/endpoint` from the configmap. Default values is `https://api.openshift.com/api/accounts_mgmt/v1/cluster_transfers/`
- `clusterTransferInterval` - frequency of checking available cluster transfers. Overwritten by `clusterTransfer/interval` from the configmap. Default value is `24h`.
- `conditionalGathererEndpoint` - the endpoing providing conditional gathering rules definitions. Overwritten by `dataReporting/conditionalGathererEndpoint` from the configmap. Default value is `https://console.redhat.com/api/gathering/gathering_rules`.
- `disableInsightsAlerts` - disables the insights alerts for when the insights operator is disabled. Overwritten by `alerting/disabled` from the configmap. Default value is `false`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disables the insights alerts for when the insights operator is disabled

I think I don't understand this sentence. This disables all the alerts registered by the Insights Operator by default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected, thanks!

@tremes
Copy link
Contributor

tremes commented Jan 9, 2024

/approve

Copy link

openshift-ci bot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoaoFula, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2024
@tremes
Copy link
Contributor

tremes commented Jan 17, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2024
@JoaoFula
Copy link
Contributor Author

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 17, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD e13c6a4 and 2 for PR HEAD c546fa0 in total

@tremes
Copy link
Contributor

tremes commented Jan 17, 2024

/override ci/prow/e2e-gcp-ovn-techpreview

Copy link

openshift-ci bot commented Jan 17, 2024

@tremes: Overrode contexts on behalf of tremes: ci/prow/e2e-gcp-ovn-techpreview

In response to this:

/override ci/prow/e2e-gcp-ovn-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 3ce28f3 into openshift:master Jan 17, 2024
Copy link

openshift-ci bot commented Jan 17, 2024

@JoaoFula: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-insights-operator-container-v4.16.0-202401171849.p0.g3ce28f3.assembly.stream for distgit ose-insights-operator.
All builds following this will include this PR.

JoaoFula added a commit to JoaoFula/insights-operator that referenced this pull request Jan 23, 2024
…penshift#892)

* Adding insights-config configmap definition to docs and associating it to the support secret.

* Following revision's correction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants