OCPBUGS-34784: Collect aggregated Prometheus Alertmanager instances

[ncaak]

This PR implements a new data enhancement to the gatherers. It creates a new gatherer that collects instances of Prometheus and AlertManager deployments that are outside of the openshift-monitoring namespace.

Categories

• Bugfix
• Data Enhancement
• Feature
• Backporting
• Others (CI, Infrastructure, Documentation)

Sample Archive

• docs/insights-archive-sample/config/aggregated/custom_prometheuses_alertmanagers.json

Documentation

• docs/gathered-data.md

Unit Tests

• pkg/gatherers/clusterconfig/gather_aggregated_instances_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

• No

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-12758
https://issues.redhat.com/browse/OCPBUGS-34784

[openshift-ci-robot]

@ncaak: This pull request references CCXDEV-12758 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

This PR implements a new data enhancement to the gatherers. It creates a new gatherer that collects instances of Prometheus and AlertManager deployments that are outside of the openshift-monitoring namespace.

Categories

• Bugfix
• Data Enhancement
• Feature
• Backporting
• Others (CI, Infrastructure, Documentation)

Sample Archive

• docs/insights-archive-sample/config/aggregated/custom_prometheuses_alertmanagers.json

Documentation

• docs/gathered-data.md

Unit Tests

• pkg/gatherers/clusterconfig/gather_aggregated_instances_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

• No

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-12758

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ncaak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tremes]

Thank you!
/lgtm

[ncaak]

/retest

[openshift-ci]

@ncaak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@ncaak: This pull request references CCXDEV-12758 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

This PR implements a new data enhancement to the gatherers. It creates a new gatherer that collects instances of Prometheus and AlertManager deployments that are outside of the openshift-monitoring namespace.

Categories

• Bugfix
• Data Enhancement
• Feature
• Backporting
• Others (CI, Infrastructure, Documentation)

Sample Archive

• docs/insights-archive-sample/config/aggregated/custom_prometheuses_alertmanagers.json

Documentation

• docs/gathered-data.md

Unit Tests

• pkg/gatherers/clusterconfig/gather_aggregated_instances_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

• No

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-12758
https://issues.redhat.com/browse/OCPBUGS-34784

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@ncaak: This pull request references Jira Issue OCPBUGS-34784, which is invalid:

• expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "4.16.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR implements a new data enhancement to the gatherers. It creates a new gatherer that collects instances of Prometheus and AlertManager deployments that are outside of the openshift-monitoring namespace.

Categories

• Bugfix
• Data Enhancement
• Feature
• Backporting
• Others (CI, Infrastructure, Documentation)

Sample Archive

• docs/insights-archive-sample/config/aggregated/custom_prometheuses_alertmanagers.json

Documentation

• docs/gathered-data.md

Unit Tests

• pkg/gatherers/clusterconfig/gather_aggregated_instances_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

• No

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-12758
https://issues.redhat.com/browse/OCPBUGS-34784

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ncaak]

/jira refresh

[openshift-ci-robot]

@ncaak: This pull request references Jira Issue OCPBUGS-34784, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.0) matches configured target version for branch (4.17.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @JoaoFula

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@ncaak: Jira Issue OCPBUGS-34784: All pull requests linked via external trackers have merged:

• openshift/insights-operator#941

Jira Issue OCPBUGS-34784 has been moved to the MODIFIED state.

In response to this:

This PR implements a new data enhancement to the gatherers. It creates a new gatherer that collects instances of Prometheus and AlertManager deployments that are outside of the openshift-monitoring namespace.

Categories

• Bugfix
• Data Enhancement
• Feature
• Backporting
• Others (CI, Infrastructure, Documentation)

Sample Archive

• docs/insights-archive-sample/config/aggregated/custom_prometheuses_alertmanagers.json

Documentation

• docs/gathered-data.md

Unit Tests

• pkg/gatherers/clusterconfig/gather_aggregated_instances_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

• No

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-12758
https://issues.redhat.com/browse/OCPBUGS-34784

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-insights-operator-container-v4.17.0-202406031213.p0.g90d750b.assembly.stream.el9 for distgit ose-insights-operator.
All builds following this will include this PR.

[ncaak]

/cherry-pick 4.16

[openshift-cherrypick-robot]

@ncaak: cannot checkout 4.16: error checking out "4.16": exit status 1 error: pathspec '4.16' did not match any file(s) known to git

In response to this:

/cherry-pick 4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ncaak]

/cherry-pick release-4.16

[openshift-cherrypick-robot]

@ncaak: new pull request created: #948

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ncaak]

/cherry-pick release-4.15

[openshift-cherrypick-robot]

@ncaak: new pull request created: #950

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.