types/openstack: drop GetImageNames method

With baseimage user query removed from TUI, this function is no longer required.

This also
- drops the vendored files
- updates the mocks using `hack/go-genmock.sh`

pkg/types/openstack/validation/platform_test.go

@@ -27,7 +27,6 @@ func TestValidatePlatform(t *testing.T) {
 		platform   *openstack.Platform
 		noClouds   bool
 		noRegions  bool
-		noImages   bool
 		noNetworks bool
 		noFlavors  bool
 		noNetExts  bool
@@ -127,15 +126,6 @@ func TestValidatePlatform(t *testing.T) {
 					Return([]string{"test-region"}, nil).
 					MaxTimes(1)
 			}
-			if tc.noImages {
-				fetcher.EXPECT().GetImageNames(tc.platform.Cloud).
-					Return(nil, errors.New("no images")).
-					MaxTimes(1)
-			} else {
-				fetcher.EXPECT().GetImageNames(tc.platform.Cloud).
-					Return([]string{"test-image"}, nil).
-					MaxTimes(1)
-			}
 			if tc.noNetworks {
 				fetcher.EXPECT().GetNetworkNames(tc.platform.Cloud).
 					Return(nil, errors.New("no networks")).

pkg/types/openstack/validation/realvalidvaluesfetcher.go

@@ -4,7 +4,6 @@ import (
 	"github.com/gophercloud/gophercloud/openstack/common/extensions"
 	"github.com/gophercloud/gophercloud/openstack/compute/v2/flavors"
 	"github.com/gophercloud/gophercloud/openstack/identity/v3/regions"
-	"github.com/gophercloud/gophercloud/openstack/imageservice/v2/images"
 	netext "github.com/gophercloud/gophercloud/openstack/networking/v2/extensions"
 	"github.com/gophercloud/gophercloud/openstack/networking/v2/networks"
 	"github.com/gophercloud/utils/openstack/clientconfig"
@@ -62,36 +61,6 @@ func (f realValidValuesFetcher) GetRegionNames(cloud string) ([]string, error) {
 	return regionNames, nil
 }
 
-// GetImageNames gets the valid image names.
-func (f realValidValuesFetcher) GetImageNames(cloud string) ([]string, error) {
-	opts := &clientconfig.ClientOpts{
-		Cloud: cloud,
-	}
-
-	conn, err := clientconfig.NewServiceClient("image", opts)
-	if err != nil {
-		return nil, err
-	}
-
-	listOpts := images.ListOpts{}
-	allPages, err := images.List(conn, listOpts).AllPages()
-	if err != nil {
-		return nil, err
-	}
-
-	allImages, err := images.ExtractImages(allPages)
-	if err != nil {
-		return nil, err
-	}
-
-	imageNames := make([]string, len(allImages))
-	for x, image := range allImages {
-		imageNames[x] = image.Name
-	}
-
-	return imageNames, nil
-}
-
 // GetNetworkNames gets the valid network names.
 func (f realValidValuesFetcher) GetNetworkNames(cloud string) ([]string, error) {
 	opts := &clientconfig.ClientOpts{

pkg/types/openstack/validation/validvaluesfetcher.go

@@ -8,8 +8,6 @@ type ValidValuesFetcher interface {
 	GetCloudNames() ([]string, error)
 	// GetRegionNames gets the valid region names.
 	GetRegionNames(cloud string) ([]string, error)
-	// GetImageNames gets the valid image names.
-	GetImageNames(cloud string) ([]string, error)
 	// GetNetworkNames gets the valid network names.
 	GetNetworkNames(cloud string) ([]string, error)
 	// GetFlavorNames gets the valid flavor names.

pkg/types/validation/installconfig_test.go

@@ -282,7 +282,6 @@ func TestValidateInstallConfig(t *testing.T) {
 			fetcher := mock.NewMockValidValuesFetcher(mockCtrl)
 			fetcher.EXPECT().GetCloudNames().Return([]string{"test-cloud"}, nil).AnyTimes()
 			fetcher.EXPECT().GetRegionNames(gomock.Any()).Return([]string{"test-region"}, nil).AnyTimes()
-			fetcher.EXPECT().GetImageNames(gomock.Any()).Return([]string{"test-image"}, nil).AnyTimes()
 			fetcher.EXPECT().GetNetworkNames(gomock.Any()).Return([]string{"test-network"}, nil).AnyTimes()
 			fetcher.EXPECT().GetFlavorNames(gomock.Any()).Return([]string{"test-flavor"}, nil).AnyTimes()
 			fetcher.EXPECT().GetNetworkExtensionsAliases(gomock.Any()).Return([]string{"trunk"}, nil).AnyTimes()