Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/asset/ignition/bootstrap: Bump etcd to 3.3.10 #1060

Closed
wants to merge 1 commit into from

Conversation

wking
Copy link
Member

@wking wking commented Jan 12, 2019

Catching the bootstrap's health-checker up with the masters, which were bumped to 3.3.10 in openshift/machine-config-operator@59f80967 (openshift/machine-config-operator#205). Sam Batschelet motivated that change with:

Currently OpenShift 4.0 installs are using an old version of etcd v3.2.14. This PR bumps that to 3.3.10 which will be the release version.

Tangentially related to #1059, which also talks about etcd versions.

Catching the bootstrap's health-checker up with the masters, which
were bumped to 3.3.10 in openshift/machine-config-operator@59f80967
(templates: bump etcd to v3.3.10, 2018-11-30,
openshift/machine-config-operator#205).  Sam Batschelet motivated that
change with [1]:

  Currently OpenShift 4.0 installs are using an old version of etcd
  v3.2.14.  This PR bumps that to 3.3.10 which will be the release
  version.

[1]: openshift/machine-config-operator#205
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 12, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2019
@openshift-ci-robot
Copy link
Contributor

@wking: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 3e8681b link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking
Copy link
Member Author

wking commented Feb 7, 2019

Once openshift/etcd#3 lands we'll be able to get etcdctl via the update-payload by leaning on the just-landed #1194. That will obsolete this approach, so...

/close

@openshift-ci-robot
Copy link
Contributor

@wking: Closed this PR.

In response to this:

Once openshift/etcd#3 lands we'll be able to get etcdctl via the update-payload by leaning on the just-landed #1194. That will obsolete this approach, so...

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the etcd-3.3.10 branch February 7, 2019 07:01
@wking
Copy link
Member Author

wking commented Feb 26, 2019

We ended up getting an explicit bump to 3.3.10 anyway in #1304.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants