pkg/types/aws/machinepool: Drop IAM-role overrides

[wking]

We're planning on dropping instance profiles in favor of the new credentials operator, because we want AWS access to have operator/pod/namespace granularity and not instance granularity. Many pods could be running on a given instance, and not all of them should have a given permission. While we're blocked from dropping these at the moment due to kubelet cloud-config+secrets, we can drop the user-facing knobs for this feature now. Then pivoting the internal approach once we get the kubelet sorted will be a non-breaking change.

CC @rajatchopra.

[wking]

I've pushed 5b46586 -> dca6982, fixing some broken installConfigVersion -> InstallConfigVersion references (I'd initially waffled over whether the constant should be public).

[wking]

image timed out awaiting headers (openshift/release#2505).

/test images
/test e2e-aws

[wking]

/retest

[wking]

images:

2019/01/31 00:21:46 Copied 0.27Mi of artifacts from release-latest to /logs/artifacts/release-latest
2019/01/31 00:21:46 error: unable to signal to artifacts container to terminate in pod release-latest, triggering deletion: could not run remote command: unable to upgrade connection: container not found ("artifacts")
2019/01/31 00:21:51 Ran for 7m8s
error: could not run steps: test "release-latest" failed: pod release-latest was already deleted

/retest

[wking]

I've pushed 93df306 -> 5b005cb to address:

level=fatal msg="failed to fetch Terraform Variables: failed to load asset \"Install Config\": invalid \"install-config.yaml\" file: apiVersion: Invalid value: \"v1beta1\": install-config version must be \"v1beta2\""

because CI continues to supply the v1beta1 install config (although it does not set the property I'm removing).

[wking]

images:

2019/02/01 06:50:36 Container artifacts in pod release-latest completed successfully
2019/02/01 06:50:51 error: unable to signal to artifacts container to terminate in pod release-latest, triggering deletion: could not run remote command: unable to upgrade connection: container not found ("artifacts")
2019/02/01 06:50:51 error: unable to retrieve artifacts from pod release-latest: could not read gzipped artifacts: unable to upgrade connection: container not found ("artifacts")
2019/02/01 06:50:57 Ran for 23m50s

/retest

[wking]

images:

2019/02/01 09:19:46 Container artifacts in pod release-latest completed successfully
2019/02/01 09:19:57 error: unable to signal to artifacts container to terminate in pod release-latest, triggering deletion: could not run remote command: unable to upgrade connection: container not found ("artifacts")
2019/02/01 09:19:57 error: unable to retrieve artifacts from pod release-latest: could not read gzipped artifacts: unable to upgrade connection: container not found ("artifacts")
2019/02/01 09:20:03 Ran for 27m5s
error: could not run steps: test "release-latest" failed: pod release-latest was already deleted

Probably the CI master CPU pegging from last night.

/retest

[wking]

e2e-aws:

level=info msg="Waiting up to 30m0s for the cluster to initialize..."
level=fatal msg="failed to initialize the cluster: timed out waiting for the condition"

/retest

[wking]

All green :)

[crawford]

I consider this a bug fix.

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [crawford,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[wking]

@dgoodwin, @vrutkovs: I think it's very unlikely that you were setting the role-name override, but you'll need to bump your generated install-config version string before we can remove this. Can you let me know when you have?