data: route53 A records with SimplePolicy should not use health check

[derekwaynecarr]

masters appear to take 3-5m to resolve their ignition config due to timeout.

according to https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/resource-record-sets-values-alias.html#rrsets-values-alias-alias-target , aws docs claim we should not enable health checking if using simple policy.

testing this out to see if it helps drop ignition config time.

[derekwaynecarr]

/hold

fyi @smarterclayton

[derekwaynecarr]

while this looks to be the correct setup per the doc, it does not have an impact on time to serve ignition.

from what i can tell, we create the master, and 2m later we get the A record created from terraform logs. that aligns with the ~3m wait we see waiting for ignition to be served.

[derekwaynecarr]

@sjenning i dont think i see an obvious way of reducing this lag for masters to get ignition config. i see masters created in terraform, and then the a-records get created 2-3m later, and if you look at the master bootlogs, they are basically waiting for that a-record to exist before soon after they get data.

[derekwaynecarr]

ordering terraform is not my expertise, but i dont see us making an improvement without doing something in that area.

[wking]

We've been carrying evaluate_target_health = true since 805e443 (2017-02-24), which seems to have landed in master without a pull-request or other discussion. I don't see any motivation for the previous choice, and the linked docs' "If you have only one record that has a given name and type, Route 53 responds to DNS queries using the values in that record regardless of whether the resource is healthy.", makes sense to me.

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[abhinavdahiya]

/hold cancel

[wking]

e2e-aws:

level=error msg="\t* aws_route_table_association.route_net.0: timeout while waiting for state to become 'success' (timeout: 5m0s)"

/retest