Proposal for BYO deployment

[FlorinPeter]

The motivation behind this PR is to be able to solve our security requirements by using our own Terraform files and plugins for the supported platforms.
The use of self defined Terraform files should always respecting the boundaries given by the installer.
If the byo is set via the install-config.yaml then the installer will not unpack the platform specific files and expects them in the specified installer directory.

[openshift-ci-robot]

Hi @FlorinPeter. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FlorinPeter
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: russellb

If they are not already assigned, you can assign the PR to them by writing /assign @russellb in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[DanyC97]

@FlorinPeter wouldn't the output generated by the installer be enough to then deploy the cluster on top of your infrastructure created with your self defined Terraform files?

i'm trying to understand why the installer should extend its scope to allow custom terrafform files, what is the benefit ? is that going to be the case for majority of BYO users ?

[FlorinPeter]

@DanyC97 from my point of view it is also a possibility to only consume the generated ignition files but the installer is currently not only generating the ignition files.
There is also some logic that waits for till the bootstrap is done and and destroy it afterwards or add the router certificate.
This means that all this logic needs to be self organized in a BYO scenario.
In the end the effort to write a copy of this installer is much more then to allow the users be able participate from this logic that is already here.
For sure there are some boundries that are given by the installer but for my point of view it is much less effort to allow to overwrite the baked in Terraform files instead of writing a copy of this installer.
This feature will enable users to have customized deployments especially for OpenStack as there are a lot of variations out in the field which requires sometimes different settings for dns or loadbalancing.

[FlorinPeter]

close in favor of #1393