Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/types/aws/validation: Require machine-pool zones in platform region #1469

Merged
merged 1 commit into from
Mar 28, 2019
Merged

pkg/types/aws/validation: Require machine-pool zones in platform region #1469

merged 1 commit into from
Mar 28, 2019

Commits on Mar 26, 2019

  1. pkg/types/aws/validation: Require machine-pool zones in platform region 

    In the excitement of a zone outage, this one bit me [1], leading to
errors like [2]:

  ERROR  * module.masters.aws_network_interface.master[1]: key "us-east-1c" does not exist in map var.az_to_subnet_id in:
  ERROR
  ERROR ${var.az_to_subnet_id[var.availability_zones[count.index]]}
  ERROR  * module.masters.aws_network_interface.master[2]: key "us-east-1d" does not exist in map var.az_to_subnet_id in:
  ERROR
  ERROR ${var.az_to_subnet_id[var.availability_zones[count.index]]}
  ERROR  * module.masters.aws_network_interface.master[0]: key "us-east-1a" does not exist in map var.az_to_subnet_id in:
  ERROR
  ERROR ${var.az_to_subnet_id[var.availability_zones[count.index]]}
  ERROR  * module.bootstrap.var.subnet_id: key "us-east-1a" does not exist in map module.vpc.az_to_public_subnet_id in:
  ERROR
  ERROR ${module.vpc.az_to_public_subnet_id[var.aws_master_availability_zones[0]]}

With this commit, we require zones in the configured region before
getting into Terraform, and we describe the mismatch with words that
are hopefully more obvious to jumpy users ;).

[1]: openshift/release#3204 (comment)
[2]: openshift/release#3204 (comment)
    @wking
    wking committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    f25961d View commit details
    Browse the repository at this point in the history