-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: user platform validation expects sorted list of platforms #1498
Conversation
Hi @serbrech. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: serbrech If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
You can't add to platform list in not sorted order. installer/pkg/types/installconfig_test.go Line 10 in 3cadc45
|
If you think that relying on the unit test is better than to not have to care about the order, feel free to close this. Every new platform will just have to make sure they add their own name in the right spot in the list. Instead of assuming a sorted list, what about making |
some previous dicussion is here, here and here. /close |
@abhinavdahiya: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
if the list of platform is not sorted, the validation will fail, as the index returned by SearchString will not match the index of the platform string found, and the equality check will fail.