Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: don't make openshift unit wait for kas #1659

Merged
merged 1 commit into from
Apr 23, 2019

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Apr 22, 2019

The openshift unit runs after the bootkube unit, so the control plane is up.
We no longer have any need to wait.

Alternative #1658
/assign @wking

The openshift unit runs after the bootkube unit, so the control plane is up.
We no longer have any need to wait.
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 22, 2019
@wking
Copy link
Member

wking commented Apr 22, 2019

Checking an unrelated job that failed to install (and so has collected bootstrap logs):

$ curl -s https://storage.googleapis.com/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade/543/artifacts/e2e-aws-upgrade/bootstrap/bootkube.service | head -n1
Apr 22 18:31:14 ip-10-0-5-105 bootkube.sh[1507]: Pulling release image...
$ curl -s https://storage.googleapis.com/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade/543/artifacts/e2e-aws-upgrade/bootstrap/openshift.service | head -n1
Apr 22 18:31:13 ip-10-0-5-105 openshift.sh[1508]: Waiting for pods in namespace openshift-kube-apiserver...

so this is clearly running before bootkube.service succeeds. Long-term, I'd like to remove openshift.sh and move those manifests over to cluster-bootstrap's post-pod phase (see a stale, early stab at this in #1147). But I don't have a problem with polling these pushed until they go through in the meantime.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2019
@deads2k
Copy link
Contributor Author

deads2k commented Apr 22, 2019

infra, docker pull

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Apr 22, 2019

docker build strategy

/test all

@openshift-merge-robot openshift-merge-robot merged commit c310f1a into openshift:master Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants