Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data/bootstrap: update etcd-signer-server to use certs for api and api-int #1670

Merged

Conversation

abhinavdahiya
Copy link
Contributor

Requires etcd-signer-server to support multiple certs for serving 1

Currently the etcd-signer-server only serves request using api-int serving certificate which causes errors like,

time="2019-04-24T13:25:11-07:00" level=debug msg="Still waiting for the Kubernetes API: Get https://api.adahiya-0.tt.testing:6443/version?timeout=32s: x509: certificate is valid for api-int.adahiya-0.tt.testing, not api.adahiya-0.tt.testing"

as the installer is hitting the etcd-signer-server on api.$cluster_domain.

Setting up etcd-signer-server to use multiple certs ie one for api and another for api-int allows both internal and external client to hot etcd-signer-server and not get x509 errors.

…i-int

Requires etcd-signer-server to support multiple certs for serving [1]

Currently the etcd-signer-server only serves request using `api-int` serving certificate which causes errors like,

```console
time="2019-04-24T13:25:11-07:00" level=debug msg="Still waiting for the Kubernetes API: Get https://api.adahiya-0.tt.testing:6443/version?timeout=32s: x509: certificate is valid for api-int.adahiya-0.tt.testing, not api.adahiya-0.tt.testing"
```

as the installer is hitting the etcd-signer-server on api.$cluster_domain.

Setting up etcd-signer-server to use multiple certs ie one for api and another for api-int allows both internal and external client to hot etcd-signer-server and not get x509 errors.

[1]: coreos/kubecsr#28
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 24, 2019
@wking
Copy link
Member

wking commented Apr 24, 2019

Requires etcd-signer-server to support multiple certs for serving

/hold

Wait for coreos/kubecsr#28.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2019
@wking
Copy link
Member

wking commented Apr 24, 2019

And, once that lands and then gets percolated up into openshift/kubecsr, this:

/lgtm

so anyone can pull the /hold ;).

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member

wking commented Apr 26, 2019

openshift/kubecsr#14 landed.

/retest

@trown
Copy link

trown commented Apr 26, 2019

/test e2e-openstack

@abhinavdahiya
Copy link
Contributor Author

/retest

@abhinavdahiya
Copy link
Contributor Author

/hold cancel

with this change:
https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_installer/1670/pull-ci-openshift-installer-master-e2e-aws/5565/artifacts/e2e-aws/installer/.openshift_install.log

time="2019-04-26T08:00:18Z" level=info msg="Waiting up to 30m0s for the Kubernetes API at https://api.ci-op-n87yf9yy-1d3f3.origin-ci-int-aws.dev.rhcloud.com:6443..."
time="2019-04-26T08:00:48Z" level=debug msg="Still waiting for the Kubernetes API: Get https://api.ci-op-n87yf9yy-1d3f3.origin-ci-int-aws.dev.rhcloud.com:6443/version?timeout=32s: dial tcp 3.83.60.156:6443: connect: connection refused"
time="2019-04-26T08:01:28Z" level=debug msg="Still waiting for the Kubernetes API: the server could not find the requested resource"
time="2019-04-26T08:01:58Z" level=debug msg="Still waiting for the Kubernetes API: the server could ...
time="2019-04-26T08:05:30Z" level=debug msg="Still waiting for the Kubernetes API: the server could not find the requested resource"
time="2019-04-26T08:05:46Z" level=debug msg="Still waiting for the Kubernetes API: Get https://api.ci-op-n87yf9yy-1d3f3.origin-ci-int-aws.dev.rhcloud.com:6443/version?timeout=32s: dial tcp 3.210.135.62:6443: connect: connection refused"
time="2019-04-26T08:06:07Z" level=info msg="API v1.13.4+efe7dba up"

without this change:
https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_installer/1681/pull-ci-openshift-installer-master-e2e-aws/5571/artifacts/e2e-aws/installer/.openshift_install.log

time="2019-04-26T16:16:08Z" level=info msg="Waiting up to 30m0s for the Kubernetes API at https://api.ci-op-8q8923rw-1d3f3.origin-ci-int-aws.dev.rhcloud.com:6443..."
time="2019-04-26T16:16:08Z" level=debug msg="Still waiting for the Kubernetes API: Get https://api.ci-op-8q8923rw-1d3f3.origin-ci-int-aws.dev.rhcloud.com:6443/version?timeout=32s: dial tcp 3.209.122.241:6443: connect: connection refused"
time="2019-04-26T16:16:10Z" level=debug msg="Still waiting for the Kubernetes API: Get https://api.ci-op-8q8923rw-1d3f3.origin-ci-int-aws.dev.rhcloud.com:6443/version?timeout=32s: x509: certificate is valid for api-int.ci-op-8q8923rw-1d3f3.origin-ci-int-aws.dev.rhcloud.com, not api.ci-op-8q8923rw-1d3f3.origin-ci-int-aws.dev.rhcloud.com"
...
time="2019-04-26T16:19:49Z" level=debug msg="Still waiting for the Kubernetes API: Get https://api.ci-op-8q8923rw-1d3f3.origin-ci-int-aws.dev.rhcloud.com:6443/version?timeout=32s: dial tcp 3.209.122.241:6443: connect: connection refused"
time="2019-04-26T16:20:16Z" level=info msg="API v1.13.4+fcf1eaf up"

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@wking
Copy link
Member

wking commented Apr 26, 2019

e2e-aws:

level=error msg="\t* aws_route.igw_route: Error creating route: timeout while waiting for state to become 'success' (timeout: 2m0s)"

Hopefully mitigated once #1682 lands.

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@abhinavdahiya
Copy link
Contributor Author

/refresh

@openshift-merge-robot openshift-merge-robot merged commit 9d17730 into openshift:master Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants