Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase of #168 to hopefully fix CI #177

Closed
wants to merge 3 commits into from
Closed

Conversation

eparis
Copy link
Member

@eparis eparis commented Aug 24, 2018

No description provided.

Now that the etcd members have been moved to the master nodes, there is
no need for the etcd nodes.
This should have been remove back in 45fa0e4.
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eparis
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: smarterclayton

If they are not already assigned, you can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 24, 2018
@openshift-ci-robot
Copy link
Contributor

@eparis: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws e7d5a79 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@eparis
Copy link
Member Author

eparis commented Aug 24, 2018

I'm going to close this rebase of #168 since just a rebase wasn't enough.

@eparis eparis closed this Aug 24, 2018
@eparis eparis deleted the fix-ci branch August 29, 2018 20:59
EmilienM pushed a commit to shiftstack/installer that referenced this pull request Dec 8, 2020
Currently when provider tries to update cluster status, it gets error:

  User "system:serviceaccount:openstack-provider-system:default" cannot update resource "clusters/status" in API group "cluster.k8s.io" in the namespace "default"

This happens because "status" is separate subresource and access to it
must be granted separately.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants