-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gather: add support for azure #1795
Conversation
This change enables the gather bootstrap subcommand to output the necessary commands to execute based on an Azure cluster's tfstate.
/test e2e-aws-scaleup-rhel7 |
/approve /cc @patrickdillon @jcpowermac |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, jcpowermac, jstuever The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
/skip |
/retest Please review the full test history for this PR and help us cut down flakes. |
@jstuever: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
This changes the gather bootstrap to establish an SSH connection to bootstrap host to gather the logs, rather than printing the commands for the user to execute. This had some trivial conflicts because e4bddc2 (gather: add support for azure, 2019-05-28, openshift#1795) had landed in release-4.2 but does not apply to 4.1, where we have no Azure support.
This change enables the gather bootstrap subcommand to output the
necessary commands to execute based on an Azure cluster's tfstate.
https://jira.coreos.com/browse/CORS-1099